feat: build with esbuild #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for blobs-js ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
github-actions
bot
added
the
type: feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this pull request solving?
In this repository we take a TypeScript source and generate both a Node.js module (using
tscto transpile) and a Deno module. Sadly,tscand Deno disagree about the correct way to import a TypeScript file, with the former not supporting the.tsextension in import paths and the latter requiring it.Right now this isn't a problem because we have a simple entry point file that is not importing anything, but once the codebase becomes more complex and we need to break it out into separate files, we'll have a problem.
To prevent that, this PR replaces
tscwith esbuild, which does let you import TypeScript files with a.tsextension. We're still usingtscfor type checking, but it's esbuild who actually transpiles the code.