(WIP) Add GitLab Backend #517

tech4him1 · 2017-08-08T01:50:27Z

- Summary

Add support for GitLab as a backend. This version does not support the editorial workflow. Fixes #57. This PR copies the code from #508, so those fixes can be used for this backend as well. It is also (re)based on #560 -- once that one is merged this will be rebased.

- Todos

- Test plan

Manually tested with the example project and a "real" project.

- Description for the changelog

Add support for GitLab as a backend (simple workflow only).

tech4him1 · 2017-08-15T23:16:24Z

@zanedev brought up the fact that the current implementation does not work with OAuth access_tokens that expire. As far as I can tell, Netlify's OAuth server does not currently return refresh_tokens, so if left logged in, the CMS eventually just stops working. A user must log out and log back in to make the CMS start working again.

Benaiah

Quick review of request and fileExists in the GitLab API.

Benaiah · 2017-08-29T23:50:53Z

src/backends/gitlab/API.js

+      }
+      return Promise.all([response, response.text()]);
+    })
+    .catch(err => [err, null])


This should be .catch(err => Promise.reject([err, null)) so the other .catch block catches and destructures it properly. This is my bad - it's the same way in my GH API refactor PR.

Benaiah · 2017-08-30T00:02:20Z

src/backends/gitlab/API.js

+    .catch(([errorValue, response]) => {
+      const errorMessageProp = (errorValue && errorValue.message) ? errorValue.message : null;
+      const message = errorMessageProp || (isString(errorValue) ? errorValue : "");
+      throw new APIError(message, response && response.status, 'GitHub', { response, errorValue });


Change 'GitHub' to 'GitLab'

Benaiah · 2017-08-30T00:11:05Z

src/backends/gitlab/API.js

+    }).then(() => true).catch((err) => {
+      // TODO: 404 can mean either the file does not exist, or if an API
+      //   endpoint doesn't exist. Is there a better way to check for this?
+      if (err.status === 404) {return false;} else {throw err;}


You can change this whole block to .catch(err => (err.status === 404 ? false : Promise.reject(err))). I think the 404 check is fine, unless GitLab has something more specific we can check (you can access the whole response object as err.meta).

The problem is that with a HEAD request, we don't actually get the content of the error message back, so we can't tell the difference.

cbarrett · 2017-10-02T18:52:46Z

Is this still in progress? I'm interested in working on this (in fact have already started before I saw this.)

tech4him1 · 2017-10-02T19:06:48Z

@cbarrett @theetrain Yes, this is still in progress. Right now we have mostly been working on bugfixes and critical features for 1.0 (see https://github.com/netlify/netlify-cms/wiki/2017.09.13-Planning-Session for an update), but as soon as we get those done, we'll get back to this.

If you need to use it right now you should be able to rebase it onto master and use as-is.

suprafly · 2017-11-10T19:52:06Z

Would love to know when this is in.

nnyath · 2017-12-03T23:19:20Z

@tech4him1 is the Netlify auth api currently supported/enabled for GitLab?

I've merged your gitlab branch with 0.7.6 and got it running but I'm facing a 'No Auth Provider Found' when the pop-up window attempts to access
https://api.netlify.com/auth?provider=gitlab&site_id=cms.netlify.com&scope=repo

Also, are there any plans for direct auth since GitLab supports implicit grant?

tech4him1 · 2017-12-03T23:29:57Z

@nnyath The Netlify Auth API does support GitLab, but you will still need to set it up like you do with the GitHub backend: https://www.netlify.com/docs/authentication-providers/#using-an-authentication-provider.

That's a very good point about implicit auth, and we've actually been discussing this within the team lately. @Benaiah @erquhart Is there any reason not to allow implicit auth with the backends that support it?

Benaiah · 2018-05-07T22:29:09Z

Development has moved to #1343, which refactors the CMS and the GitLab backend to use cursors for sophisticated pagination support. While development and code review will be done there, I will continue to update this PR as we hit milestones, since so many people are subscribed here for updates.

Benaiah · 2018-05-25T21:08:32Z

#1343 is now ready for review!

…s/APIError.js`

them. This is not optimal, but it is how the GitHub implementation works and should be fixed later.

…ups.

@Benaiah

Thanks @Benaiah!

This reverts commit f789472.

`hasWriteAccess` was not working in the case where permissions were granted on a single group-owned repo, instead of the entire group.

erquhart · 2018-06-04T23:02:50Z

Rebased and added a commit for single direction pagination support.

tech4him1 force-pushed the gitlab branch 2 times, most recently from c28b852 to 4cd83f9 Compare August 8, 2017 19:36

Benaiah mentioned this pull request Aug 9, 2017

Cannot get local netlify-api backend to work #425

Closed

tech4him1 force-pushed the gitlab branch from 4cd83f9 to ef485f1 Compare August 11, 2017 21:04

tech4him1 mentioned this pull request Aug 12, 2017

Gitlab as backend. #57

Closed

tech4him1 force-pushed the gitlab branch 9 times, most recently from 9ea2caf to c3ff76d Compare August 14, 2017 23:19

tech4him1 changed the title ~~WIP: Add GitLab Backend~~ Add GitLab Backend Aug 14, 2017

tech4him1 changed the title ~~Add GitLab Backend~~ (WIP) Add GitLab Backend Aug 15, 2017

tech4him1 self-assigned this Aug 17, 2017

tech4him1 force-pushed the gitlab branch 2 times, most recently from 99d0ad9 to 1b8f2e8 Compare August 29, 2017 22:52

Benaiah previously requested changes Aug 30, 2017

View reviewed changes

tech4him1 mentioned this pull request Aug 30, 2017

WIP: Gentle re-authentication modal/popup. #560

Closed

tech4him1 mentioned this pull request Oct 10, 2017

Refactor API code for GitHub backend #508

Closed

3 tasks

verythorough mentioned this pull request Oct 12, 2017

Add instructions for auth with Netlify Identity and Git Gateway #600

Closed

10 tasks

tech4him1 mentioned this pull request Nov 28, 2017

Unknown error #849

Closed

Benaiah closed this May 7, 2018

Benaiah and others added 23 commits June 4, 2018 18:41

Add an optional meta field to APIError in `src/valueObjects/error…

847fcf5

…s/APIError.js`

Initial GitLab commit.

058dba6

Fix authentication/permission checking.

1102e79

Make images with the same filename as already existing images overwrite

e5484b4

them. This is not optimal, but it is how the GitHub implementation works and should be fixed later.

Remove unneeded dependencies.

97652f6

Remove old GitHub code.

369df6a

Code cleanup from decaporg#508.

f3e5d40

Clarify comment.

f5ecfee

Fix permission checking for GitLab projects that are in groups/subgro…

fc4e48e

…ups.

Cleanup request function and other minor cleanup.

ca7379b

Thanks @Benaiah!

migrate GitLab backend to 1.0

0b11dfd

Download GitLab files as raw

03f9d05

add restoreUser method to GitLab backend

edf1f78

update hasWriteAccess and logout for GitLab

b3771fd

add media library support for GitLab

f7550f1

fix gitlab collection caching

940edce

Add gentle re-authentication code for GitLab.

03f729b

remove old entry-plus-media persist logic

84cda50

Revert "Add gentle re-authentication code for GitLab."

8403ce0

This reverts commit f789472.

remove old entry-plus-media logic from tests

b71249e

Fix access for GitLab group-owned repos.

bd4928e

`hasWriteAccess` was not working in the case where permissions were granted on a single group-owned repo, instead of the entire group.

simplify persistFiles

8cec67f

add backend and integration pagination support

70fea9e

erquhart reopened this Jun 4, 2018

erquhart force-pushed the gitlab branch from 3bb187e to 70fea9e Compare June 4, 2018 23:00

erquhart closed this Jun 5, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

(WIP) Add GitLab Backend #517

(WIP) Add GitLab Backend #517

tech4him1 commented Aug 8, 2017 •

edited

Loading

tech4him1 commented Aug 15, 2017 •

edited

Loading

Benaiah left a comment

Benaiah Aug 29, 2017

Benaiah Aug 30, 2017

Benaiah Aug 30, 2017

tech4him1 Aug 30, 2017

cbarrett commented Oct 2, 2017

tech4him1 commented Oct 2, 2017 •

edited

Loading

suprafly commented Nov 10, 2017

nnyath commented Dec 3, 2017

tech4him1 commented Dec 3, 2017

Benaiah commented May 7, 2018

Benaiah commented May 25, 2018

erquhart commented Jun 4, 2018 •

edited

Loading

(WIP) Add GitLab Backend #517

(WIP) Add GitLab Backend #517

Conversation

tech4him1 commented Aug 8, 2017 • edited Loading

tech4him1 commented Aug 15, 2017 • edited Loading

Benaiah left a comment

Choose a reason for hiding this comment

Benaiah Aug 29, 2017

Choose a reason for hiding this comment

Benaiah Aug 30, 2017

Choose a reason for hiding this comment

Benaiah Aug 30, 2017

Choose a reason for hiding this comment

tech4him1 Aug 30, 2017

Choose a reason for hiding this comment

cbarrett commented Oct 2, 2017

tech4him1 commented Oct 2, 2017 • edited Loading

suprafly commented Nov 10, 2017

nnyath commented Dec 3, 2017

tech4him1 commented Dec 3, 2017

Benaiah commented May 7, 2018

Benaiah commented May 25, 2018

erquhart commented Jun 4, 2018 • edited Loading

tech4him1 commented Aug 8, 2017 •

edited

Loading

tech4him1 commented Aug 15, 2017 •

edited

Loading

tech4him1 commented Oct 2, 2017 •

edited

Loading

erquhart commented Jun 4, 2018 •

edited

Loading