-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added basic documentation for select widget #806
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fields: | ||
- {label: Title, name: title, widget: string, tagname: h1} | ||
- {label: Body, name: body, widget: markdown} | ||
- {label: Align Content, name: align, widget: select, options: ['left', 'center', 'right']} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Closing #764 requires documentation of adding labels and values, would you mind adding an example of that, too? You could even trim this code sample down and just show the field config examples, e.g.:
collections:
- name: posts
...
fields:
...
- { label: Align Content, <rest of field> }
- { label: Other example, <rest of field> }
@ackushiw I think it would also be nice if we note that you can use the |
Yeah, I tried this in my own project but it didn't work. I assumed this
will be added in the next release, so didn't want to jump the gun. Let me
double check though.
…On Nov 11, 2017 9:24 PM, "Caleb" ***@***.***> wrote:
@ackushiw <https://github.com/ackushiw> I think it would also be nice if
we note that you can use the default setting, to set the default option.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#806 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AF6kbI9-Tpk5vfxB-CPu3PjgHnVnOdr1ks5s1lbbgaJpZM4QanA9>
.
|
I'm going to merge this as an incremental improvement and keep #764 open for now. |
- Summary
This helps people new to the platform with using the select widget and removes the need to go digging through code to work out the implementation.
- Test plan
Used english dictionary
- Description for the changelog
closes #764
Added basic documentation for select widget
- A picture of a cute animal (not mandatory but encouraged)