Fix select widgets with object type options. #920
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tech4him1
force-pushed
the
fix-select-widgets
branch
from
3a90321 to
b091e39
Compare
|
Deploy preview ready! Built with commit 3a90321 |
|
Deploy preview ready! Built with commit b091e39 |
erquhart
approved these changes
Dec 14, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- Summary
Fix select widgets with object keys causing the entire CMS to crash. The problem was just an improper import from Immutable.js.
- Test plan
Select widgets with object options work now.
- Description for the changelog
Fix select widgets with object type options.
- A picture of a cute animal (not mandatory but encouraged)