fix: patch new lmdb binary location #322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🌟 Deploy Preview for netlify-plugin-gatsby-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
tiffafoo
approved these changes
Mar 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this pull request solving?
Gatsby uses some native binaries our SSR/DSG lambdas, most importantly the lmdb database engine. To handle differing ABI versions between the node versions in build machines and lambdas, we patch the Gatsby query engine bundle and manually copy binaries before deploying. A recent update to lmdb changed the name of the binary, which was correctly moved, but the bundle was not correctly patched, causing missing binaries when deployed.
List other issues or pull requests related to this problem
Fixes #294
Describe the solution you've chosen
I've fixed this by adding the new import string to the list of patches