feat: handle number and object responses correctly in functions #440
Conversation
✅ Deploy Preview for netlify-plugin-gatsby-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
orinokai
changed the title
orinokai
force-pushed
the
rs/function-res-content-types
branch
2 times, most recently
from
c7ce05c to
43e869a
Compare
package.json
Outdated
| @@ -38,7 +38,7 @@ | |||
| }, | |||
| "devDependencies": { | |||
| "@netlify/build": "^27.4.0", | |||
| "@netlify/eslint-config-node": "6.0.0", | |||
| "@netlify/eslint-config-node": "5.1.8", | |||
There was a problem hiding this comment.
downgraded to avoid lint errors with module resolution after syncing package.json and package-lock.json
There was a problem hiding this comment.
Odd that this is happening 🤔 Is it the rules within this project that are causing these issues?
There was a problem hiding this comment.
Are the errors related to the files you've changed, or elsewhere? If they're not related to your changes then it seems like this shouldbe a different PR: i.e. you do a separate PR to update the package-lock and if that breaks the linting, make the linting changes in there rather than in this unrelated PR
plugin/package.json
Outdated
| @@ -71,7 +72,7 @@ | |||
| "npm-run-all": "^4.1.5", | |||
| "rimraf": "^3.0.2", | |||
| "tmp-promise": "^3.0.3", | |||
| "typescript": "^4.5.2" | |||
| "typescript": "4.6.4" | |||
There was a problem hiding this comment.
upgraded to avoid ts.resolveTypeReferenceDirective error after syncing package.json and package-lock.json
There was a problem hiding this comment.
[dust] Should this be the following instead?
| "typescript": "4.6.4" | |
| "typescript": "^4.6.4" |
Or do we want to start pinning to specific versions to prevent issues going forward during package upgrades?
| @@ -133,7 +134,7 @@ export const createResponseObject = ({ onResEnd }) => { | |||
| response.statusCode = statusCode | |||
| }, | |||
| }) | |||
| res.headers = { 'content-type': 'text/plain; charset=utf-8' } | |||
| res.headers = { 'content-type': 'text/html; charset=utf-8' } | |||
There was a problem hiding this comment.
default content type changed to html to match gatsby serve
package.json
Outdated
| @@ -38,7 +38,7 @@ | |||
| }, | |||
| "devDependencies": { | |||
| "@netlify/build": "^27.4.0", | |||
| "@netlify/eslint-config-node": "6.0.0", | |||
| "@netlify/eslint-config-node": "5.1.8", | |||
There was a problem hiding this comment.
Odd that this is happening 🤔 Is it the rules within this project that are causing these issues?
plugin/package.json
Outdated
| @@ -71,7 +72,7 @@ | |||
| "npm-run-all": "^4.1.5", | |||
| "rimraf": "^3.0.2", | |||
| "tmp-promise": "^3.0.3", | |||
| "typescript": "^4.5.2" | |||
| "typescript": "4.6.4" | |||
There was a problem hiding this comment.
[dust] Should this be the following instead?
| "typescript": "4.6.4" | |
| "typescript": "^4.6.4" |
Or do we want to start pinning to specific versions to prevent issues going forward during package upgrades?
orinokai
force-pushed
the
rs/function-res-content-types
branch
from
954aa7d to
2e35993
Compare
orinokai
force-pushed
the
rs/function-res-content-types
branch
from
2e35993 to
9ac9098
Compare
Summary
We currently handle Gatsby's function response helpers (basiclaly Express's
sendandjson) by adding our own implementations to the mocked HTTP ServerResponse object that is sent back from the function lambda.However, our implementations don't handle some types in the same way as Express and this PR addresses that.
Specifically:
sendare now stringified unless they are Buffers (which are now served with the correct content type)sendare used as the status code and the relevant status message is sent as the bodyTest plan
Tests are in progress
Relevant links (GitHub issues, Notion docs, etc.) or a picture of cute animal