fix: clear redirects/rewrites produced by previous builds and generate functions in ntl dev #738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for netlify-plugin-gatsby-demo-v5 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for netlify-plugin-gatsby-demo ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
pieh
changed the title
pieh
commented
Jan 5, 2024
| constants, | ||
| }: NetlifyPluginOptions): Promise<void> { | ||
| // eslint-disable-next-line no-param-reassign | ||
| netlifyConfig.build.environment.GATSBY_PRECOMPILE_DEVELOP_FUNCTIONS = `true` |
There was a problem hiding this comment.
Gatsby compiles functions lazily in dev (waiting for /api/X to be requested before function is compiled) by default which cause problems if we want to wrap them - this will force compile them eagerly
pieh
commented
Jan 5, 2024
Comment on lines
+217
to
+219
| contents: neededFunctions.includes('API') | ||
| ? '/api/* /.netlify/functions/__api 200' | ||
| : '', |
There was a problem hiding this comment.
this now always handles redirects - if API is "not needed" - it will clean up dangling redirect
pieh
changed the title
kathmbeck
approved these changes
Jan 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Reverts #724 + adds fixes needed:
ntl devclears.netlify/functions-internalso we have to (re)generate them. Alternatively we could skip that and rely on gatsby dev server handling functions however this movesntl devfurther away from builds (+ there is some quirk with with CLI where*/x-www-form-urlencodedandmultipart/form-datarequests are not proxied to dev server at least currently).This also clears out redirects produced by
gatsby-plugin-netlifyANDgatsby-adapter-netlifyif builld happened before - those redirects would be for DSG/SSR functions that can't work in dev, because gatsby doesn't even produce engines in dev and DSG/SSR pages are handled just the same as SSG pages in devTest plan
Relevant links (GitHub issues, Notion docs, etc.) or a picture of cute animal
FRA-181
Standard checks:
🧪 Once merged, make sure to update the version if needed and that it was
published correctly.