Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ValidationContext using is not correct in UUIDValidator #297

Closed
qiunju opened this issue Jun 4, 2020 · 1 comment
Closed

ValidationContext using is not correct in UUIDValidator #297

qiunju opened this issue Jun 4, 2020 · 1 comment

Comments

@qiunju
Copy link
Contributor

qiunju commented Jun 4, 2020

super(schemaPath, schemaNode, parentSchema, ValidatorTypeCode.DATETIME, validationContext);

Hi, @stevehu
I guess what we want to verify here is UUID, so it should be ValidatorTypeCode.UUID.
I created a PR for it: https://github.com/networknt/json-schema-validator/pull/298/files
Please correct if I'm wrong. Thanks!

@qiunju qiunju changed the title "ValidatorTypeCode" using is not correct "ValidationContext" using is not correct in UUIDValidator Jun 4, 2020
@stevehu
Copy link
Contributor

stevehu commented Jun 4, 2020

@qiunju Yes. It is a copy/paste error. Thanks a lot for fixing it.

@stevehu stevehu closed this as completed Jun 4, 2020
@stevehu stevehu changed the title "ValidationContext" using is not correct in UUIDValidator ValidationContext using is not correct in UUIDValidator Jun 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants