Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating Codegen Docker Images and Storage on Dockerhub #550

Open
soaapp opened this issue Mar 4, 2021 · 5 comments
Open

Updating Codegen Docker Images and Storage on Dockerhub #550

soaapp opened this issue Mar 4, 2021 · 5 comments
Labels
1.6.x Merge to 1.6.x Branch

Comments

@soaapp
Copy link

soaapp commented Mar 4, 2021

Resume the creation of codgen docker images and storage on dockerhub

@stevehu
Copy link
Contributor

stevehu commented Mar 5, 2021

@soaapp The latest and 1.6.32 has have been released to the docker hub. Please double-check after the 1.6.33 release at the end of the month to ensure that the light-bot build will release the new version for each 1.6.x release. Thanks.

https://hub.docker.com/layers/networknt/light-codegen/1.6.32/images/sha256-6463bbd5cfacc13642066471274dc568e6593180a626bcd4d0dfb5f782f64f5b?context=repo

Let's close the issue when we see the 1.6.33 release on the docker hub.

@soaapp
Copy link
Author

soaapp commented Apr 6, 2021

@stevehu I believe the 1.6.33 release was completed at the end of March but it seems the light-bot did not release for each 1.6.x. If possible, the docker image creation for 1.6.26 is required. Thank you for your help.

@stevehu
Copy link
Contributor

stevehu commented Apr 6, 2021

Here is the 1.6.33 released by the light-bot several days ago.

https://hub.docker.com/layers/143301627/networknt/light-codegen/1.6.33/images/sha256-f0e1bdc4daf919208945f8ce676b51c5abf362da4718ee9989a757606cfcf716?context=explore

We cannot release something with a previous tag by light-bot. I am wondering if you could upgrade your tutorial with 1.6.33 tag.

@soaapp
Copy link
Author

soaapp commented Apr 6, 2021

It currently need 1.6.26 as that is the versioning we support for it. Is there anyway that image can be added as well?

@stevehu
Copy link
Contributor

stevehu commented Apr 6, 2021

@soaapp I checked the Dockerfile and it uses the latest code from the 1.6.x branch, not from the tag. We cannot go back to the time to build the docker image without a customized Dockerfile to do so.

https://github.com/networknt/light-docker/blob/1.6.x/light-codegen/Dockerfile#L9

If you look at the 1.6.26 release, we do have the codegen-cli.jar attached. You can use that jar file to build a customized docker image and publish it to your internal docker registry. If you want to publish to the public docker hub, please submit a PR in the light-docker and I can run it to publish to networknt.

https://github.com/networknt/light-codegen/releases/tag/1.6.26

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.6.x Merge to 1.6.x Branch
Projects
None yet
Development

No branches or pull requests

2 participants