Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request API Change: Add registration_time for nse registration #115

Closed
denis-tingaikin opened this issue Nov 1, 2021 · 3 comments · Fixed by #116
Closed

Request API Change: Add registration_time for nse registration #115

denis-tingaikin opened this issue Nov 1, 2021 · 3 comments · Fixed by #116
Assignees

Comments

@denis-tingaikin
Copy link
Member

denis-tingaikin commented Nov 1, 2021

Suggestion

Add registration_time for the network service endpoints.

message NetworkServiceEndpoint {
    string name = 1;
    repeated string network_service_names = 2;
    map<string, NetworkServiceLabels> network_service_labels = 3;
    string url = 4;
    google.protobuf.Timestamp expiration_time = 5;
    google.protobuf.Timestamp initial_registration_time = 6;
}

How it will be used

expiration_time updates by registry by each refresh register.

registration_time will be set once per registration by the registry side.

registration_time can be used for statistics goals and also for identity issues and sorting issues.

Motivation

  1. Solves Registry heal works incorrect if NSMgr changes IP address after restart sdk#1079
  2. Solves Simultaneous creation of multiple vl3-NSEs cmd-nse-vl3-vpp#3
@denis-tingaikin
Copy link
Member Author

@edwarnicke WDYT?

@edwarnicke
Copy link
Member

@denis-tingaikin Might it make more sense to call it initial_registration_time?

@denis-tingaikin
Copy link
Member Author

@edwarnicke I think yes :)

The description is updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants