Some of helper functions are wrong and some of them are not using

[denis-tingaikin]

We need to recheck all helper functions in api and probabbly cover them by unut tests.

Some of helper functions are wrong.

1. See at https://github.com/networkservicemesh/api/blob/main/pkg/api/networkservice/ipcontext_helpers.go#L192 //Note: this makes ipNet incorrect

2. This is not using

   api/pkg/api/networkservice/connection_helpers.go

   Line 37 in ad449d9

   func (x *Connection) GetSourceNetworkServiceManagerName() string {

   and its wrong

3. This is not using

   api/pkg/api/networkservice/connection_helpers.go

   Line 48 in ad449d9

   func (x *Connection) GetDestinationNetworkServiceManagerName() string {

   and its wrong

Solution

1. Cleanup helpers
2. (?) Add unit tests

[denis-tingaikin]

@edwarnicke Can we schedule this for v1.5.0?

[NikitaSkrynnik]

Seems like done: #152