Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update References commits are not signed and trigger integration-k8s-kind CI during releasing #11593

Open
NikitaSkrynnik opened this issue Apr 1, 2024 · 1 comment
Open

Update References commits are not signed and trigger integration-k8s-kind CI during releasing #11593

NikitaSkrynnik opened this issue Apr 1, 2024 · 1 comment
Assignees
@edwarnicke @NikitaSkrynnik

Comments

@NikitaSkrynnik
Copy link
Collaborator

Description

  1. Update References workflow is triggered by PRs merged during releases. This behaviour triggers integration-k8s-kind CI
  2. Commits created by Update References workflow are not signed

Solution

  1. Remove automerge is completed trigger from Update References workflow.
  2. Use GPG keys to sign commits
@NikitaSkrynnik NikitaSkrynnik mentioned this issue Apr 1, 2024
Open
9 tasks
@NikitaSkrynnik NikitaSkrynnik self-assigned this Apr 2, 2024
@NikitaSkrynnik
Copy link
Collaborator Author

Solutions for unsigned commits

  1. Use GPG keys. Described here.
  2. Make commits using Github API. In this case the commit's author will be github-actions[bot] (instead of nsmbot)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@edwarnicke edwarnicke

@NikitaSkrynnik NikitaSkrynnik

Labels
None yet
Projects
Release v1.13.0
Status: Blocked
Milestone
No milestone
Development

No branches or pull requests
2 participants
@edwarnicke @NikitaSkrynnik