-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce tokens time from 24h to 10 minutes for each application #906
Comments
@denis-tingaikin Did this get done? If not, why not? |
It is not done. It looks like we missed this ticket. Will do. As I can see we can simply set there 10m https://github.com/networkservicemesh/deployments-k8s/blob/main/examples/spire/server-configmap.yaml#L19 |
@denis-tingaikin Token expirationTime is min(svid expirationTime, now + maxTimeout as set by env variable)... I was suggesting we fix maxTimeout's default value from 24h to 10 minutes, not that we change the Spire svid lifetime. |
Motivation
Previously we've fixed issues with
refresh
/timeout
:networkservicemesh/sdk#778
networkservicemesh/sdk#650
networkservicemesh/sdk#520
and now we can reduce tokens expiration for each application to 10 minutes (it is 24h at this moment).
Also, we plan to add
refresh
/timeout
examples, but it can be done separately:https://github.com/orgs/networkservicemesh/projects/1#card-55928687
https://github.com/orgs/networkservicemesh/projects/1#card-55928794
The text was updated successfully, but these errors were encountered: