Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce tokens time from 24h to 10 minutes for each application #906

Closed
denis-tingaikin opened this issue Apr 20, 2021 · 3 comments
Closed
Assignees
Labels
enhancement New feature or request

Comments

@denis-tingaikin
Copy link
Member

denis-tingaikin commented Apr 20, 2021

Motivation

Previously we've fixed issues with refresh/timeout:

networkservicemesh/sdk#778
networkservicemesh/sdk#650
networkservicemesh/sdk#520

and now we can reduce tokens expiration for each application to 10 minutes (it is 24h at this moment).

Also, we plan to add refresh/timeout examples, but it can be done separately:
https://github.com/orgs/networkservicemesh/projects/1#card-55928687
https://github.com/orgs/networkservicemesh/projects/1#card-55928794

@denis-tingaikin denis-tingaikin changed the title Reduce tokens time to 10 minutes for each application Reduce tokens time from 24h to 10 minutes for each application Apr 20, 2021
@denis-tingaikin denis-tingaikin added the enhancement New feature or request label Apr 20, 2021
@edwarnicke
Copy link
Member

@denis-tingaikin Did this get done? If not, why not?

@denis-tingaikin
Copy link
Member Author

It is not done. It looks like we missed this ticket.

Will do. As I can see we can simply set there 10m https://github.com/networkservicemesh/deployments-k8s/blob/main/examples/spire/server-configmap.yaml#L19

@edwarnicke
Copy link
Member

@denis-tingaikin Token expirationTime is min(svid expirationTime, now + maxTimeout as set by env variable)... I was suggesting we fix maxTimeout's default value from 24h to 10 minutes, not that we change the Spire svid lifetime.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants