-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ethernetcontext and ipcontext client #227
Comments
/cc @edwarnicke , @Bolodya1997 |
I guess creating |
@Bolodya1997 @pperiyasamy Might it make more sense to consider moving: https://github.com/networkservicemesh/sdk-vpp/tree/main/pkg/networkservice/connectioncontextkernel to sdk-kernel? Please note, doing so would also imply moving: https://github.com/networkservicemesh/sdk-vpp/tree/main/pkg/tools/mechutils @pperiyasamy @Bolodya1997 Thoughts? |
@pperiyasamy I also have PRs for: Implement connectioncontextkernel/ethernetcontext/getmac That might be interesting to you as sources of suggestions... if we decide to move connectioncontextkernel to sdk-kernel, we probably want to consider implementing those here as well. |
@edwarnicke yes, we can merge sdk-vpp's contextcontextkernel and sdk-kernel's ethernetcontext/ipcontext packages and have it under sdk-kernel/pkg/kernel/networkservice/connectioncontextkernel having both client and server handlers and make vpp and sriov forwarders consume it from this package. does it make sense ? |
/cc @JanScheurich |
The sdk-kernel repo contains ethernetcontext and ipcontext packages which support configuring mac address, ip and routes on network service client container, can we have client.go module so that same support is available for endpoint container. Most of the generic code can be moved under common.go.
There is also netns server code which runs subsequent server handler code under client container network namespace.
Should we also have such implementation for running ipcontext client for endpoint container ? or can that logic be part of ipcontext client module itself ?
The text was updated successfully, but these errors were encountered: