Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ethernetcontext and ipcontext client #227

Closed
pperiyasamy opened this issue May 12, 2021 · 6 comments · Fixed by #231
Closed

ethernetcontext and ipcontext client #227

pperiyasamy opened this issue May 12, 2021 · 6 comments · Fixed by #231
Labels
enhancement New feature or request good first issue Good for newcomers question Further information is requested

Comments

@pperiyasamy
Copy link
Member

The sdk-kernel repo contains ethernetcontext and ipcontext packages which support configuring mac address, ip and routes on network service client container, can we have client.go module so that same support is available for endpoint container. Most of the generic code can be moved under common.go.
There is also netns server code which runs subsequent server handler code under client container network namespace.
Should we also have such implementation for running ipcontext client for endpoint container ? or can that logic be part of ipcontext client module itself ?

@denis-tingaikin denis-tingaikin added the good first issue Good for newcomers label May 12, 2021
@denis-tingaikin denis-tingaikin added bug Something isn't working question Further information is requested and removed bug Something isn't working labels May 12, 2021
@denis-tingaikin
Copy link
Member

/cc @edwarnicke , @Bolodya1997

@denis-tingaikin denis-tingaikin added the enhancement New feature or request label May 12, 2021
@Bolodya1997
Copy link

I guess creating ipcontext client is a good idea.

@edwarnicke
Copy link
Member

@edwarnicke
Copy link
Member

@pperiyasamy I also have PRs for:

Implement connectioncontextkernel/ethernetcontext/getmac
Implement connectioncontext/ethernetcontext/macaddress
Implement connectioncontextkernel/ethernetcontext/macaddress

That might be interesting to you as sources of suggestions... if we decide to move connectioncontextkernel to sdk-kernel, we probably want to consider implementing those here as well.

@pperiyasamy
Copy link
Member Author

@edwarnicke yes, we can merge sdk-vpp's contextcontextkernel and sdk-kernel's ethernetcontext/ipcontext packages and have it under sdk-kernel/pkg/kernel/networkservice/connectioncontextkernel having both client and server handlers and make vpp and sriov forwarders consume it from this package. does it make sense ?

@pperiyasamy
Copy link
Member Author

/cc @JanScheurich

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers question Further information is requested
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants