Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move mechutils#ToInterfaceName into sdk or api repo #254

Closed
pperiyasamy opened this issue Jun 8, 2021 · 3 comments
Closed

move mechutils#ToInterfaceName into sdk or api repo #254

pperiyasamy opened this issue Jun 8, 2021 · 3 comments
Assignees
Labels
ASAP As soon as possible bug Something isn't working Planning Issue related to SOW

Comments

@pperiyasamy
Copy link
Member

The mechutils#ToInterfaceName method is generic and is used to retrieve client or endpoint container interface name from forwarder perspective, if this moved into sdk or api repo, chain elements in other sdk-* can reuse it.
some of the sdk-kernel and sdk-sriov chain elements still uses mechanism.InterfaceName(conn) method to retrieve interface name which is logically incorrect. for example connectioncontextkernel , because of this cmd-forwarder-vpp ci is failing when sdk-vpp adapts to use it.

@denis-tingaikin denis-tingaikin added the Planning Issue related to SOW label Jul 5, 2021
@denis-tingaikin
Copy link
Member

@edwarnicke, @pperiyasamy We'll look at the issue.
We'll have assigned some one from team tomorrow.

@denis-tingaikin denis-tingaikin added ASAP As soon as possible bug Something isn't working labels Jul 5, 2021
@edwarnicke
Copy link
Member

Something to keep in mind... the solution should be:

  • If the client has not assigned an interface name, assign it using the client's connection id
  • If the endpoint has not assigned a name, assign it using the endpoints connection id

I suspect that putting something in api and into the client and server endpoint chains may be the correct way to handle this.

Also, please test solution with cmd-forwarder-vpp

@denis-tingaikin
Copy link
Member

@pperiyasamy It looks like all pieces done. Closing this. Be free to reopen if we missed something.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ASAP As soon as possible bug Something isn't working Planning Issue related to SOW
Projects
None yet
Development

No branches or pull requests

4 participants