Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NSMgr should pass Close() calls #570

Closed
1 of 3 tasks
xzfc opened this issue Nov 5, 2020 · 2 comments · Fixed by #571
Closed
1 of 3 tasks

NSMgr should pass Close() calls #570

xzfc opened this issue Nov 5, 2020 · 2 comments · Fixed by #571
Assignees
@xzfc
Labels
bug Something isn't working

Comments

@xzfc
Copy link
Contributor

xzfc commented Nov 5, 2020 •
edited
Loading

Currently, NSMgr ignores incoming NetworkService Close() calls so that the corresponding NSE never receives them. More precisely, it is ignored by discover which is a part of NSMgr chain.

Related PR that introduced this behavior: #263.

To-do:
@xzfc xzfc added the bug Something isn't working label Nov 5, 2020
@xzfc xzfc self-assigned this Nov 5, 2020
@xzfc xzfc mentioned this issue Nov 6, 2020
Merged
@xzfc
Copy link
Contributor Author

xzfc commented Nov 12, 2020

Reopening as there are unfinished to-dos.

@xzfc xzfc reopened this Nov 12, 2020
@denis-tingaikin
Copy link
Member

denis-tingaikin commented Mar 22, 2022 •
edited
Loading

The problem is resolved. Currently we have tests that covers closes and unregisters:
For example https://github.com/networkservicemesh/sdk/blob/main/pkg/networkservice/chains/nsmgr/heal_test.go#L283-L289

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xzfc xzfc

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

discoverServer: handle Close
2 participants
@xzfc @denis-tingaikin