Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add registry netnsmonitor chain element #666

Open
denis-tingaikin opened this issue Jan 25, 2021 · 0 comments
Open

Add registry netnsmonitor chain element #666

denis-tingaikin opened this issue Jan 25, 2021 · 0 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@denis-tingaikin
Copy link
Member

denis-tingaikin commented Jan 25, 2021

Motivation

nsmgr could detect endpoints/forwarders death momentarily if we add functionality for monitoring netns.

Currently, we are using netns monitor in monorepo in healing scenarious.

Implementation details

  1. sednfd, recvfd registry chain elements know endpoint's inode. Probably we can share inode of the endpoint for the next chain in Register/Unregister.
  2. add a new registry chain element netnsmonitor.
  3. Implement it as it is implemented in monorepo https://github.com/networkservicemesh/networkservicemesh/blob/027edac3488b4c511df465c36b62889586d81820/forwarder/pkg/common/monitor_netnsinode_server.go#L49. Note: in a death case, we need to send an update with expiration time < 0.
  4. Add the chain element into nsmgr chain: https://github.com/networkservicemesh/sdk/blob/master/pkg/networkservice/chains/nsmgr/server.go#L136
  5. Add sandbox tests to cover the new functionality.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants