Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add groupipam networkservice server chain element #1407

Merged
merged 2 commits into from
Jan 9, 2023
Merged

feat: add groupipam networkservice server chain element #1407

merged 2 commits into from
Jan 9, 2023

Conversation

denis-tingaikin
Copy link
Member

Signed-off-by: denis-tingaikin denis.tingajkin@xored.com

Description

Reduces code for nses.

For example, these lines could be removed with this patch

  1. https://github.com/networkservicemesh/cmd-nse-icmp-responder/blob/main/main.go#L409-L415
  2. https://github.com/networkservicemesh/cmd-nse-icmp-responder-vpp/blob/main/main.go#L328-L334
  3. https://github.com/networkservicemesh/cmd-nse-remote-vlan/blob/main/main.go#L318-L329

How Has This Been Tested?

  • Added unit testing to cover
  • Tested manually
  • Tested by integration testing
  • Have not tested

Types of changes

  • Bug fix
  • New functionallity
  • Documentation
  • Refactoring
  • CI

@denis-tingaikin
add groupipam networkservice server chain element
6ef22cf 
Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>
@denis-tingaikin
fix linter
a4816f1 
Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>
@denis-tingaikin
Copy link
Member Author

@glazychev-art , @edwarnicke Could you have a look?

@denis-tingaikin denis-tingaikin self-assigned this Jan 9, 2023
@edwarnicke edwarnicke merged commit 61629de into main Jan 9, 2023
nsmbot pushed a commit to networkservicemesh/cmd-cluster-info-k8s that referenced this pull request Jan 9, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
bed0045 
…k@main

PR link: networkservicemesh/sdk#1407

Commit: 61629de
Author: Denis Tingaikin
Date: 2023-01-10 02:03:50 +0300
Message:
  - feat: add groupipam networkservice server chain element (#1407)
* add groupipam networkservice server chain element

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>

* fix linter

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/sdk-kernel that referenced this pull request Jan 9, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
f49b200 
…k@main

PR link: networkservicemesh/sdk#1407

Commit: 61629de
Author: Denis Tingaikin
Date: 2023-01-10 02:03:50 +0300
Message:
  - feat: add groupipam networkservice server chain element (#1407)
* add groupipam networkservice server chain element

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>

* fix linter

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsc-init that referenced this pull request Jan 9, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
d91c445 
…k@main

PR link: networkservicemesh/sdk#1407

Commit: 61629de
Author: Denis Tingaikin
Date: 2023-01-10 02:03:50 +0300
Message:
  - feat: add groupipam networkservice server chain element (#1407)
* add groupipam networkservice server chain element

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>

* fix linter

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsmgr that referenced this pull request Jan 9, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
5491008 
…k@main

PR link: networkservicemesh/sdk#1407

Commit: 61629de
Author: Denis Tingaikin
Date: 2023-01-10 02:03:50 +0300
Message:
  - feat: add groupipam networkservice server chain element (#1407)
* add groupipam networkservice server chain element

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>

* fix linter

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-ipam-vl3 that referenced this pull request Jan 9, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
2bc696f 
…k@main

PR link: networkservicemesh/sdk#1407

Commit: 61629de
Author: Denis Tingaikin
Date: 2023-01-10 02:03:50 +0300
Message:
  - feat: add groupipam networkservice server chain element (#1407)
* add groupipam networkservice server chain element

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>

* fix linter

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-admission-webhook-k8s that referenced this pull request Jan 9, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
df848cd 
…k@main

PR link: networkservicemesh/sdk#1407

Commit: 61629de
Author: Denis Tingaikin
Date: 2023-01-10 02:03:50 +0300
Message:
  - feat: add groupipam networkservice server chain element (#1407)
* add groupipam networkservice server chain element

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>

* fix linter

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-registry-proxy-dns that referenced this pull request Jan 9, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
dd80ed0 
…k@main

PR link: networkservicemesh/sdk#1407

Commit: 61629de
Author: Denis Tingaikin
Date: 2023-01-10 02:03:50 +0300
Message:
  - feat: add groupipam networkservice server chain element (#1407)
* add groupipam networkservice server chain element

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>

* fix linter

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-map-ip-k8s that referenced this pull request Jan 9, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
4ffd043 
…k@main

PR link: networkservicemesh/sdk#1407

Commit: 61629de
Author: Denis Tingaikin
Date: 2023-01-10 02:03:50 +0300
Message:
  - feat: add groupipam networkservice server chain element (#1407)
* add groupipam networkservice server chain element

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>

* fix linter

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-registry-memory that referenced this pull request Jan 9, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
d17a02c 
…k@main

PR link: networkservicemesh/sdk#1407

Commit: 61629de
Author: Denis Tingaikin
Date: 2023-01-10 02:03:50 +0300
Message:
  - feat: add groupipam networkservice server chain element (#1407)
* add groupipam networkservice server chain element

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>

* fix linter

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/sdk-k8s that referenced this pull request Jan 9, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
e65f67b 
…k@main

PR link: networkservicemesh/sdk#1407

Commit: 61629de
Author: Denis Tingaikin
Date: 2023-01-10 02:03:50 +0300
Message:
  - feat: add groupipam networkservice server chain element (#1407)
* add groupipam networkservice server chain element

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>

* fix linter

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nse-remote-vlan that referenced this pull request Jan 9, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
b6e0064 
…k@main

PR link: networkservicemesh/sdk#1407

Commit: 61629de
Author: Denis Tingaikin
Date: 2023-01-10 02:03:50 +0300
Message:
  - feat: add groupipam networkservice server chain element (#1407)
* add groupipam networkservice server chain element

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>

* fix linter

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsmgr-proxy that referenced this pull request Jan 9, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
3838ac1 
…k@main

PR link: networkservicemesh/sdk#1407

Commit: 61629de
Author: Denis Tingaikin
Date: 2023-01-10 02:03:50 +0300
Message:
  - feat: add groupipam networkservice server chain element (#1407)
* add groupipam networkservice server chain element

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>

* fix linter

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nse-vfio that referenced this pull request Jan 9, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
811131b 
…k@main

PR link: networkservicemesh/sdk#1407

Commit: 61629de
Author: Denis Tingaikin
Date: 2023-01-10 02:03:50 +0300
Message:
  - feat: add groupipam networkservice server chain element (#1407)
* add groupipam networkservice server chain element

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>

* fix linter

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
This was referenced Jan 9, 2023
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
This was referenced Jan 9, 2023
Merged
Merged
@denis-tingaikin denis-tingaikin mentioned this pull request Jan 10, 2023
Closed
This was referenced Jan 11, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edwarnicke edwarnicke edwarnicke approved these changes

@glazychev-art glazychev-art Awaiting requested review from glazychev-art

Assignees

@denis-tingaikin denis-tingaikin

Labels
None yet
Projects
Release v1.8.0
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@denis-tingaikin @edwarnicke