Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moved to using a generic map instead of generated maps #1421

Merged
merged 1 commit into from
Feb 16, 2023
Merged

Moved to using a generic map instead of generated maps #1421

merged 1 commit into from
Feb 16, 2023

Conversation

wazsone
Copy link
Contributor

@wazsone wazsone commented Feb 15, 2023

Description

Replaces generated code with go generics

Issue link

#1420

How Has This Been Tested?

  • Added unit testing to cover
  • Tested manually
  • Tested by integration testing
  • Have not tested

Types of changes

  • Bug fix
  • New functionality
  • Documentation
  • Refactoring
  • CI

@wazsone wazsone self-assigned this Feb 15, 2023
@wazsone wazsone force-pushed the feature/genericmaps branch from 6043965 to d72942f Compare February 15, 2023 10:27
@codecov
Copy link

codecov bot commented Feb 15, 2023 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (main@438ec05). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1421   +/-   ##
=======================================
  Coverage        ?   70.03%           
=======================================
  Files           ?      242           
  Lines           ?    10950           
  Branches        ?        0           
=======================================
  Hits            ?     7669           
  Misses          ?     2782           
  Partials        ?      499

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@wazsone
Moved to using a generic map instead of generated maps
077192a 
Signed-off-by: Ruslan Bayandinov <wazsone@ya.ru>
@wazsone wazsone force-pushed the feature/genericmaps branch from d72942f to 077192a Compare February 15, 2023 13:27
@wazsone wazsone marked this pull request as ready for review February 15, 2023 13:44
@denis-tingaikin denis-tingaikin merged commit 4d17795 into networkservicemesh:main Feb 16, 2023
nsmbot pushed a commit to networkservicemesh/cmd-admission-webhook-k8s that referenced this pull request Feb 16, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
2f654fe 
…k@main

PR link: networkservicemesh/sdk#1421

Commit: 4d17795
Author: Ruslan Bayandinov
Date: 2023-02-16 15:35:32 +0600
Message:
  - Moved to using a generic map instead of generated maps (#1421)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/sdk-kernel that referenced this pull request Feb 16, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
54bb391 
…k@main

PR link: networkservicemesh/sdk#1421

Commit: 4d17795
Author: Ruslan Bayandinov
Date: 2023-02-16 15:35:32 +0600
Message:
  - Moved to using a generic map instead of generated maps (#1421)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-map-ip-k8s that referenced this pull request Feb 16, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
a7797f4 
…k@main

PR link: networkservicemesh/sdk#1421

Commit: 4d17795
Author: Ruslan Bayandinov
Date: 2023-02-16 15:35:32 +0600
Message:
  - Moved to using a generic map instead of generated maps (#1421)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-ipam-vl3 that referenced this pull request Feb 16, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
a5df708 
…k@main

PR link: networkservicemesh/sdk#1421

Commit: 4d17795
Author: Ruslan Bayandinov
Date: 2023-02-16 15:35:32 +0600
Message:
  - Moved to using a generic map instead of generated maps (#1421)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-cluster-info-k8s that referenced this pull request Feb 16, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
41f0989 
…k@main

PR link: networkservicemesh/sdk#1421

Commit: 4d17795
Author: Ruslan Bayandinov
Date: 2023-02-16 15:35:32 +0600
Message:
  - Moved to using a generic map instead of generated maps (#1421)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nse-vfio that referenced this pull request Feb 16, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
0187147 
…k@main

PR link: networkservicemesh/sdk#1421

Commit: 4d17795
Author: Ruslan Bayandinov
Date: 2023-02-16 15:35:32 +0600
Message:
  - Moved to using a generic map instead of generated maps (#1421)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-registry-memory that referenced this pull request Feb 16, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
c63d2e6 
…k@main

PR link: networkservicemesh/sdk#1421

Commit: 4d17795
Author: Ruslan Bayandinov
Date: 2023-02-16 15:35:32 +0600
Message:
  - Moved to using a generic map instead of generated maps (#1421)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsmgr that referenced this pull request Feb 16, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
a424091 
…k@main

PR link: networkservicemesh/sdk#1421

Commit: 4d17795
Author: Ruslan Bayandinov
Date: 2023-02-16 15:35:32 +0600
Message:
  - Moved to using a generic map instead of generated maps (#1421)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsc-init that referenced this pull request Feb 16, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
123ffc9 
…k@main

PR link: networkservicemesh/sdk#1421

Commit: 4d17795
Author: Ruslan Bayandinov
Date: 2023-02-16 15:35:32 +0600
Message:
  - Moved to using a generic map instead of generated maps (#1421)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-registry-proxy-dns that referenced this pull request Feb 16, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
20dc932 
…k@main

PR link: networkservicemesh/sdk#1421

Commit: 4d17795
Author: Ruslan Bayandinov
Date: 2023-02-16 15:35:32 +0600
Message:
  - Moved to using a generic map instead of generated maps (#1421)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsmgr-proxy that referenced this pull request Feb 16, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
6c3e735 
…k@main

PR link: networkservicemesh/sdk#1421

Commit: 4d17795
Author: Ruslan Bayandinov
Date: 2023-02-16 15:35:32 +0600
Message:
  - Moved to using a generic map instead of generated maps (#1421)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nse-remote-vlan that referenced this pull request Feb 16, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
37049a9 
…k@main

PR link: networkservicemesh/sdk#1421

Commit: 4d17795
Author: Ruslan Bayandinov
Date: 2023-02-16 15:35:32 +0600
Message:
  - Moved to using a generic map instead of generated maps (#1421)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
@nsmbot nsmbot mentioned this pull request Feb 16, 2023
Merged
nsmbot pushed a commit to networkservicemesh/sdk-k8s that referenced this pull request Feb 16, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
6a6fba5 
…k@main

PR link: networkservicemesh/sdk#1421

Commit: 4d17795
Author: Ruslan Bayandinov
Date: 2023-02-16 15:35:32 +0600
Message:
  - Moved to using a generic map instead of generated maps (#1421)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
This was referenced Feb 16, 2023
Merged
Merged
Merged
Merged
Merged
Merged
@nsmbot nsmbot mentioned this pull request Feb 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@denis-tingaikin denis-tingaikin denis-tingaikin approved these changes

@glazychev-art glazychev-art Awaiting requested review from glazychev-art

Assignees

@wazsone wazsone

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wazsone @denis-tingaikin