Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remote-vlan-nse fix; Singlepoint IPAM should not allocate broadcast address #1431

Merged

Conversation

ljkiraly
Copy link
Contributor

Single-point IPAM should not allocate broadcast address

Description

Remote vlan nse is used to provide cluster breakout. The assigned IP to the front-end NSC can not be broadcast address.

Issue link

#1430

How Has This Been Tested?

  • Added unit testing to cover
  • Tested manually
  • Tested by integration testing
  • Have not tested

Types of changes

  • Bug fix
  • New functionality
  • Documentation
  • Refactoring
  • CI

@ljkiraly ljkiraly requested a review from zolug February 24, 2023 18:05
@ljkiraly ljkiraly force-pushed the singlepointipam-fix-broadcast branch 2 times, most recently from 92b28b0 to 42b1d11 Compare February 27, 2023 13:33
@ljkiraly ljkiraly marked this pull request as ready for review February 27, 2023 13:46
…ddress

Signed-off-by: Laszlo Kiraly <laszlo.kiraly@est.tech>
@ljkiraly ljkiraly force-pushed the singlepointipam-fix-broadcast branch from 42b1d11 to 878e571 Compare February 27, 2023 13:48
@denis-tingaikin denis-tingaikin merged commit f734da7 into networkservicemesh:main Feb 28, 2023
nsmbot pushed a commit to networkservicemesh/cmd-ipam-vl3 that referenced this pull request Feb 28, 2023
…k@main

PR link: networkservicemesh/sdk#1431

Commit: f734da7
Author: Laszlo Kiraly
Date: 2023-02-28 16:45:22 +0100
Message:
  - remote-vlan-nse fix; Singlepoint IPAM should not allocate broadcast address (#1431)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-map-ip-k8s that referenced this pull request Feb 28, 2023
…k@main

PR link: networkservicemesh/sdk#1431

Commit: f734da7
Author: Laszlo Kiraly
Date: 2023-02-28 16:45:22 +0100
Message:
  - remote-vlan-nse fix; Singlepoint IPAM should not allocate broadcast address (#1431)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-cluster-info-k8s that referenced this pull request Feb 28, 2023
…k@main

PR link: networkservicemesh/sdk#1431

Commit: f734da7
Author: Laszlo Kiraly
Date: 2023-02-28 16:45:22 +0100
Message:
  - remote-vlan-nse fix; Singlepoint IPAM should not allocate broadcast address (#1431)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/sdk-kernel that referenced this pull request Feb 28, 2023
…k@main

PR link: networkservicemesh/sdk#1431

Commit: f734da7
Author: Laszlo Kiraly
Date: 2023-02-28 16:45:22 +0100
Message:
  - remote-vlan-nse fix; Singlepoint IPAM should not allocate broadcast address (#1431)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsmgr that referenced this pull request Feb 28, 2023
…k@main

PR link: networkservicemesh/sdk#1431

Commit: f734da7
Author: Laszlo Kiraly
Date: 2023-02-28 16:45:22 +0100
Message:
  - remote-vlan-nse fix; Singlepoint IPAM should not allocate broadcast address (#1431)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-admission-webhook-k8s that referenced this pull request Feb 28, 2023
…k@main

PR link: networkservicemesh/sdk#1431

Commit: f734da7
Author: Laszlo Kiraly
Date: 2023-02-28 16:45:22 +0100
Message:
  - remote-vlan-nse fix; Singlepoint IPAM should not allocate broadcast address (#1431)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsmgr-proxy that referenced this pull request Feb 28, 2023
…k@main

PR link: networkservicemesh/sdk#1431

Commit: f734da7
Author: Laszlo Kiraly
Date: 2023-02-28 16:45:22 +0100
Message:
  - remote-vlan-nse fix; Singlepoint IPAM should not allocate broadcast address (#1431)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-registry-memory that referenced this pull request Feb 28, 2023
…k@main

PR link: networkservicemesh/sdk#1431

Commit: f734da7
Author: Laszlo Kiraly
Date: 2023-02-28 16:45:22 +0100
Message:
  - remote-vlan-nse fix; Singlepoint IPAM should not allocate broadcast address (#1431)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/sdk-k8s that referenced this pull request Feb 28, 2023
…k@main

PR link: networkservicemesh/sdk#1431

Commit: f734da7
Author: Laszlo Kiraly
Date: 2023-02-28 16:45:22 +0100
Message:
  - remote-vlan-nse fix; Singlepoint IPAM should not allocate broadcast address (#1431)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsc-init that referenced this pull request Feb 28, 2023
…k@main

PR link: networkservicemesh/sdk#1431

Commit: f734da7
Author: Laszlo Kiraly
Date: 2023-02-28 16:45:22 +0100
Message:
  - remote-vlan-nse fix; Singlepoint IPAM should not allocate broadcast address (#1431)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nse-remote-vlan that referenced this pull request Feb 28, 2023
…k@main

PR link: networkservicemesh/sdk#1431

Commit: f734da7
Author: Laszlo Kiraly
Date: 2023-02-28 16:45:22 +0100
Message:
  - remote-vlan-nse fix; Singlepoint IPAM should not allocate broadcast address (#1431)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-registry-proxy-dns that referenced this pull request Feb 28, 2023
…k@main

PR link: networkservicemesh/sdk#1431

Commit: f734da7
Author: Laszlo Kiraly
Date: 2023-02-28 16:45:22 +0100
Message:
  - remote-vlan-nse fix; Singlepoint IPAM should not allocate broadcast address (#1431)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nse-vfio that referenced this pull request Feb 28, 2023
…k@main

PR link: networkservicemesh/sdk#1431

Commit: f734da7
Author: Laszlo Kiraly
Date: 2023-02-28 16:45:22 +0100
Message:
  - remote-vlan-nse fix; Singlepoint IPAM should not allocate broadcast address (#1431)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants