[qfix] Use clearer function name in extend package
#1554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1554 +/- ##
=======================================
Coverage ? 66.84%
=======================================
Files ? 259
Lines ? 12327
Branches ? 0
=======================================
Hits ? 8240
Misses ? 3567
Partials ? 520 ☔ View full report in Codecov by Sentry. |
Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>
denis-tingaikin
approved these changes
Dec 26, 2023
nsmbot
pushed a commit
to networkservicemesh/cmd-csi-driver
that referenced
this pull request
Dec 26, 2023
…k@main PR link: networkservicemesh/sdk#1554 Commit: 7c6dedd Author: Nikita Skrynnik Date: 2023-12-26 18:55:50 +1100 Message: - [qfix] Use clearer function name in `extend` package (#1554) * Use clearer function name in extend package Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> * fix golang linter Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-cluster-info-k8s
that referenced
this pull request
Dec 26, 2023
…k@main PR link: networkservicemesh/sdk#1554 Commit: 7c6dedd Author: Nikita Skrynnik Date: 2023-12-26 18:55:50 +1100 Message: - [qfix] Use clearer function name in `extend` package (#1554) * Use clearer function name in extend package Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> * fix golang linter Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/sdk-kernel
that referenced
this pull request
Dec 26, 2023
…k@main PR link: networkservicemesh/sdk#1554 Commit: 7c6dedd Author: Nikita Skrynnik Date: 2023-12-26 18:55:50 +1100 Message: - [qfix] Use clearer function name in `extend` package (#1554) * Use clearer function name in extend package Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> * fix golang linter Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-admission-webhook-k8s
that referenced
this pull request
Dec 26, 2023
…k@main PR link: networkservicemesh/sdk#1554 Commit: 7c6dedd Author: Nikita Skrynnik Date: 2023-12-26 18:55:50 +1100 Message: - [qfix] Use clearer function name in `extend` package (#1554) * Use clearer function name in extend package Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> * fix golang linter Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-ipam-vl3
that referenced
this pull request
Dec 26, 2023
…k@main PR link: networkservicemesh/sdk#1554 Commit: 7c6dedd Author: Nikita Skrynnik Date: 2023-12-26 18:55:50 +1100 Message: - [qfix] Use clearer function name in `extend` package (#1554) * Use clearer function name in extend package Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> * fix golang linter Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsc-init
that referenced
this pull request
Dec 26, 2023
…k@main PR link: networkservicemesh/sdk#1554 Commit: 7c6dedd Author: Nikita Skrynnik Date: 2023-12-26 18:55:50 +1100 Message: - [qfix] Use clearer function name in `extend` package (#1554) * Use clearer function name in extend package Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> * fix golang linter Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-registry-proxy-dns
that referenced
this pull request
Dec 26, 2023
…k@main PR link: networkservicemesh/sdk#1554 Commit: 7c6dedd Author: Nikita Skrynnik Date: 2023-12-26 18:55:50 +1100 Message: - [qfix] Use clearer function name in `extend` package (#1554) * Use clearer function name in extend package Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> * fix golang linter Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsmgr
that referenced
this pull request
Dec 26, 2023
…k@main PR link: networkservicemesh/sdk#1554 Commit: 7c6dedd Author: Nikita Skrynnik Date: 2023-12-26 18:55:50 +1100 Message: - [qfix] Use clearer function name in `extend` package (#1554) * Use clearer function name in extend package Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> * fix golang linter Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-registry-memory
that referenced
this pull request
Dec 26, 2023
…k@main PR link: networkservicemesh/sdk#1554 Commit: 7c6dedd Author: Nikita Skrynnik Date: 2023-12-26 18:55:50 +1100 Message: - [qfix] Use clearer function name in `extend` package (#1554) * Use clearer function name in extend package Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> * fix golang linter Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsmgr-proxy
that referenced
this pull request
Dec 26, 2023
…k@main PR link: networkservicemesh/sdk#1554 Commit: 7c6dedd Author: Nikita Skrynnik Date: 2023-12-26 18:55:50 +1100 Message: - [qfix] Use clearer function name in `extend` package (#1554) * Use clearer function name in extend package Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> * fix golang linter Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/sdk-k8s
that referenced
this pull request
Dec 26, 2023
…k@main PR link: networkservicemesh/sdk#1554 Commit: 7c6dedd Author: Nikita Skrynnik Date: 2023-12-26 18:55:50 +1100 Message: - [qfix] Use clearer function name in `extend` package (#1554) * Use clearer function name in extend package Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> * fix golang linter Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-map-ip-k8s
that referenced
this pull request
Dec 26, 2023
…k@main PR link: networkservicemesh/sdk#1554 Commit: 7c6dedd Author: Nikita Skrynnik Date: 2023-12-26 18:55:50 +1100 Message: - [qfix] Use clearer function name in `extend` package (#1554) * Use clearer function name in extend package Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> * fix golang linter Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-remote-vlan
that referenced
this pull request
Dec 26, 2023
…k@main PR link: networkservicemesh/sdk#1554 Commit: 7c6dedd Author: Nikita Skrynnik Date: 2023-12-26 18:55:50 +1100 Message: - [qfix] Use clearer function name in `extend` package (#1554) * Use clearer function name in extend package Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> * fix golang linter Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-vfio
that referenced
this pull request
Dec 26, 2023
…k@main PR link: networkservicemesh/sdk#1554 Commit: 7c6dedd Author: Nikita Skrynnik Date: 2023-12-26 18:55:50 +1100 Message: - [qfix] Use clearer function name in `extend` package (#1554) * Use clearer function name in extend package Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> * fix golang linter Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
This was referenced Dec 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes this comment: #1533 (review)