Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Tripplite AVR750U (0x3024). Use smart1500lcdt_scale #963

Merged
merged 3 commits into from
Apr 20, 2021

Conversation

tjmc
Copy link

@tjmc tjmc commented Jan 23, 2021

Fix for #962

@tjmc tjmc marked this pull request as ready for review January 23, 2021 00:20
drivers/tripplite-hid.c Outdated Show resolved Hide resolved
Copy link
Member

@jimklimov jimklimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks useful; a little bit to fix for easier code maintenance.

And I can't test with a device, so have to hope the change is correct for the hardware in question :)

@tjmc
Copy link
Author

tjmc commented Jan 31, 2021

Looks useful; a little bit to fix for easier code maintenance.

And I can't test with a device, so have to hope the change is correct for the hardware in question :)

Thanks for looking at the request.

from #962

/lib/nut/usbhid-ups -D -a office -u root

   0.044669     [D1] Path: UPS.PowerSummary.Input.Voltage, Type: Feature, ReportID: 0x31, Offset: 0, Size: 16, Value: 0.001192
   0.065565     [D1] Path: UPS.BatterySystem.Battery.Voltage, Type: Feature, ReportID: 0x20, Offset: 0, Size: 16, Value: 0.000137
   0.079124     [D1] Path: UPS.PowerConverter.Input.Voltage, Type: Feature, ReportID: 0x18, Offset: 0, Size: 16, Value: 0.001192

I hope I understood the response to make sure it's correct for the newer AVR750U

@jimklimov jimklimov changed the title Add AVR750U (0x3024). Use smart1500lcdt_scale Add Tripplite AVR750U (0x3024). Use smart1500lcdt_scale Apr 20, 2021
@jimklimov jimklimov merged commit 2146268 into networkupstools:master Apr 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants