Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attribute parsing partially broken #46

Closed
AlexanderPavlenko opened this issue May 22, 2012 · 1 comment
Closed

Attribute parsing partially broken #46

AlexanderPavlenko opened this issue May 22, 2012 · 1 comment

Comments

@AlexanderPavlenko
Copy link

Not really want to hunt the reason down, so here is the broken template:

%label.g-label{:for => 'input-transfer-template-repeat-number'} Время:
%input#input-transfer-template-repeat-number.g-field{:type => 'text', :name => 'transfer_template[repeat_number]', :placeholder => 'например, 14:50'}

It fails with ActionView::Template::Error Error: Parse error on line 5: Unexpected 'STRING'

Looks like it's because of the UTF-8 in placeholder attr.

@netzpirat
Copy link
Collaborator

Sorry for the trouble (again). The problem is that the attribute parsing fails to properly detect the keys. Believe me, I'm currently not happy with the quality of the attribute parsing. It started with Haml Coffee #26 and continued with #44. Both of these issues implies that the attribute parser is more flexible, and more flexible means my brain is gonna hurt so much and I can't think of all the possibilities :hurtrealbad: I also can't say no to these issues, because I really want to make a great, flexible HAML implementation (or do you stop drinking after the first shot? Nope, me either...)

I have collected a plenty of specs to ensure the parser does not break something, but as you see, there are still some cases I don't have specs for. So please keep reporting, because it ensure that this case will not fail a second time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants