-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Implemented] Make GUI attitude settings settable in the API #82
Comments
@npyoung Before I do some work on this, I wanted to ask: is there still interest in this? Could you have a look at the file I was thinking of a struct within Trajectories.API called "DescentProfileNode" which would be similar to Trajectories.DescentProfile.Node. Something like this: struct DescentProfileNode {
public double angle; // in radians
public bool horizon; // if true, angle is relative to horizon, otherwise it's relative to velocity (i.e. angle of attack)
} And in the API, there would be one function that takes four of these: void setDescentProfile(DescentProfileNode entryNode, DescentProfileNode highNode, DescentProfileNode lowNode, DescentProfileNode finalNode); Does this work for you? Preferrably, could you (or some other kOS person) submit a Pull Request? That would be really condusive to exposing what you need. |
I was about to submit a request to be able to set pro/retro from KOS. I assume this would do the same thing? |
Yes it would, but before doing anything I would like to have a little discussion with the KOS people who would implement it on the KOS side and the people who would use it in their scripts about what is actually needed and how to best design the API. But unfortunately, @npyoung has since disappeared. Hence the "needinfo" label. |
Just a heads up, I'm currently working on this 😉 |
Added properties into the API, called them @darkbushido I've made a PR into kOS that will hopefully make it into the next release of kOS, I've added the suffixes |
Next additions have been mentioned here KSP-KOS/KOS#2263 |
New API methods where added for the Descent Profile for Trajectories v2.3.2 The next release of Trajectories being v2.4.0 will also have new API methods |
Added an API method Closing as needed API methods are now implemented. |
This improvement is mainly inspired by kOS's Trajectories Addon. Right now this addon only has access to the functions provided by the Trajectories API, which means a kOS user much manually tug around sliders in the Trajectories GUI before using the predictions. Exposing the attitude settings in the API would allow kOS users to programmatically set the planned attitude at each point in the descent, enabling complete automation, and maybe even better integration with other mods.
The text was updated successfully, but these errors were encountered: