Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run tests on M1 MacOS runners #41

Closed
niksirbi opened this issue Feb 1, 2024 · 5 comments · Fixed by #44
Closed

Run tests on M1 MacOS runners #41

niksirbi opened this issue Feb 1, 2024 · 5 comments · Fixed by #44
Labels
enhancement New feature or request

Comments

@niksirbi
Copy link
Member

niksirbi commented Feb 1, 2024

GitHub has introduced runners for M1 Macs.

We should consider adding them to the test matrix.

We should also discuss whether we want to test on the older Mac runners. the new M1 runners, or both.

@niksirbi niksirbi added the enhancement New feature or request label Feb 1, 2024
@adamltyson
Copy link
Member

I think both for now. Intel macs were still sold last year.

@alessandrofelder
Copy link
Member

Crosslinking equivalent BrainGlobe issue

@niksirbi
Copy link
Member Author

niksirbi commented Feb 23, 2024

Crosslinking movement issue.

@niksirbi
Copy link
Member Author

As I figured out in this movement PR, M1 runners can just be added to the test matrix on the package side, which makes sense, because each package should make that decision independently.

So, there is not much to do about it in this repo. We could close the issue, or we could simply add the M1 runner in the example workflow file here.

@alessandrofelder
Copy link
Member

I'd maybe do the latter, as people might copy-paste in the future? But not a strong opinion

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants