From 7b019a2eaed149734939345c8839183a9bc73f26 Mon Sep 17 00:00:00 2001 From: niksirbi Date: Tue, 3 Sep 2024 11:34:36 +0100 Subject: [PATCH 1/2] use ds.sizes insted of ds.dims --- tests/test_unit/test_filtering.py | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/tests/test_unit/test_filtering.py b/tests/test_unit/test_filtering.py index 1bc59348..4b400287 100644 --- a/tests/test_unit/test_filtering.py +++ b/tests/test_unit/test_filtering.py @@ -83,8 +83,8 @@ def test_interpolate_over_time_on_position( # The number of NaNs after interpolating should be as expected assert n_nans_after == ( - valid_dataset_in_frames.dims["space"] - * valid_dataset_in_frames.dims.get("keypoints", 1) + valid_dataset_in_frames.sizes["space"] + * valid_dataset_in_frames.sizes.get("keypoints", 1) # in bboxes dataset there is no keypoints dimension * expected_n_nans_in_position ) @@ -120,7 +120,7 @@ def test_filter_by_confidence_on_position( # the number of low confidence keypoints by the number of # space dimensions assert isinstance(position_filtered, xr.DataArray) - assert n_nans == valid_input_dataset.dims["space"] * n_low_confidence_kpts + assert n_nans == valid_input_dataset.sizes["space"] * n_low_confidence_kpts @pytest.mark.parametrize( @@ -198,15 +198,15 @@ def _assert_n_nans_in_position_per_individual( # compute n nans in position after filtering per individual n_nans_after_filtering_per_indiv = { i: helpers.count_nans(position_filtered.isel(individuals=i)) - for i in range(valid_input_dataset.dims["individuals"]) + for i in range(valid_input_dataset.sizes["individuals"]) } # check number of nans per indiv is as expected - for i in range(valid_input_dataset.dims["individuals"]): + for i in range(valid_input_dataset.sizes["individuals"]): assert n_nans_after_filtering_per_indiv[i] == ( expected_nans_in_filt_position_per_indiv[i] - * valid_input_dataset.dims["space"] - * valid_input_dataset.dims.get("keypoints", 1) + * valid_input_dataset.sizes["space"] + * valid_input_dataset.sizes.get("keypoints", 1) ) # Filter position From d4ec24d318e001ac94a5f9242221c5dc7244d987 Mon Sep 17 00:00:00 2001 From: sfmig <33267254+sfmig@users.noreply.github.com> Date: Fri, 6 Sep 2024 10:31:37 +0100 Subject: [PATCH 2/2] Change .dims to .sizes in kinematics tests --- tests/test_unit/test_kinematics.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/test_unit/test_kinematics.py b/tests/test_unit/test_kinematics.py index 66822bfd..7641aeeb 100644 --- a/tests/test_unit/test_kinematics.py +++ b/tests/test_unit/test_kinematics.py @@ -128,14 +128,14 @@ def test_kinematics_with_dataset_with_nans( # compute n nans in kinematic array per individual n_nans_kinematics_per_indiv = [ helpers.count_nans(kinematic_array.isel(individuals=i)) - for i in range(valid_dataset.dims["individuals"]) + for i in range(valid_dataset.sizes["individuals"]) ] # expected nans per individual adjusted for space and keypoints dimensions expected_nans_adjusted = [ n - * valid_dataset.dims["space"] - * valid_dataset.dims.get("keypoints", 1) + * valid_dataset.sizes["space"] + * valid_dataset.sizes.get("keypoints", 1) for n in expected_nans_per_individual ] # check number of nans per individual is as expected in kinematic array