Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

report(): deal with SubDataFrame #20

Open
DominiqueMakowski opened this issue Sep 3, 2018 · 4 comments
Open

report(): deal with SubDataFrame #20

DominiqueMakowski opened this issue Sep 3, 2018 · 4 comments
Labels
bug Something isn't working help us if you're reading this Help is needed to implement something

Comments

@DominiqueMakowski
Copy link
Member

DominiqueMakowski commented Sep 3, 2018

Currently, SubDataFrames are not supported. How to address this?

function report(df::DataFrames.SubDataFrame; kwargs...)
    report(df.parent[df.rows,:]; kwargs...)
end
@DominiqueMakowski DominiqueMakowski added bug Something isn't working help us if you're reading this Help is needed to implement something labels Sep 3, 2018
@DominiqueMakowski
Copy link
Member Author

Maybe the output could be like:

Group A (n=200, 80%)
    - Var1 (...)
    - Var2 (...)
Group B (n=50, 20%)
   - Var1 (...)
   - Var2 (...)

@DominiqueMakowski
Copy link
Member Author

Possibly related: JuliaData/DataFrames.jl#1443

@pdeffebach
Copy link

With the new describe behavior in DataFrames, report might not be needed. I am working on a getting this to work with a grouped dataframe currently as well.

@DominiqueMakowski
Copy link
Member Author

Great ☺️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help us if you're reading this Help is needed to implement something
Projects
None yet
Development

No branches or pull requests

2 participants