Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Repo Structure #17

Merged
merged 10 commits into from
Jun 24, 2024
Merged

Update Repo Structure #17

merged 10 commits into from
Jun 24, 2024

Conversation

rosswhitfield
Copy link
Member

@rosswhitfield rosswhitfield commented Jun 18, 2024

Ref 5464: LiveDataServer: Update Repo Structure

What this includes:

  • Add branches "next" and "qa" and protect them
  • Add a LICENSE
  • Rearrangement of code (move live_data_server under src).
  • A add pyproject.toml that will allow python packages to be built
  • Add code coverage and reporting to codecov
  • Add pre-commit and fix linting issue
  • Automating the building of the docker image

Short description of the changes:

Long description of the changes:

Check list for the pull request

  • I have read the [CONTRIBUTING]
  • I have read the [CODE_OF_CONDUCT]
  • I have added tests for my changes
  • I have updated the documentation accordingly

Check list for the reviewer

  • I have read the [CONTRIBUTING]
  • I have verified the proposed changes
  • best software practices
    • all internal functions have an underbar, as is python standard
    • clearly named variables (better to be verbose in variable names)
    • code comments explaining the intent of code blocks
  • All the tests are passing
  • The documentation is up to date
  • code comments added when explaining intent

Manual test for the reviewer

References

@rosswhitfield rosswhitfield force-pushed the update_repo branch 5 times, most recently from 3d71d2f to bc5068c Compare June 19, 2024 06:15
Copy link

codecov bot commented Jun 19, 2024

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

@rosswhitfield rosswhitfield marked this pull request as ready for review June 20, 2024 04:27
@rosswhitfield rosswhitfield requested a review from backmari June 20, 2024 05:36
.github/workflows/publish.yml Outdated Show resolved Hide resolved
Dockerfile.coverage Outdated Show resolved Hide resolved
@rosswhitfield rosswhitfield merged commit b087a3b into next Jun 24, 2024
4 checks passed
@rosswhitfield rosswhitfield deleted the update_repo branch June 24, 2024 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants