From df4d9c2454c718fb0aa8b78abc6d318547012ab1 Mon Sep 17 00:00:00 2001 From: Jodee Varney <48965776+jodeev@users.noreply.github.com> Date: Mon, 8 Feb 2021 14:44:19 -0800 Subject: [PATCH 1/3] Update ROADMAP.md --- ROADMAP.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ROADMAP.md b/ROADMAP.md index 4a280fda4..bf21381e1 100644 --- a/ROADMAP.md +++ b/ROADMAP.md @@ -7,7 +7,7 @@ New Relic is moving toward OpenTelemetry. OpenTelemetry is a unified standard fo ## Roadmap -**The roadmap project is found [here](https://github.com/newrelic/go-agent/projects/1)**. +**The Go instrumentation roadmap project is found [here](https://github.com/orgs/newrelic/projects/24)**. This roadmap project is broken down into the following sections: From e3a6dd6e0c2beafa0fc66270258c0adb1f2acc77 Mon Sep 17 00:00:00 2001 From: Steve Willoughby Date: Fri, 12 Mar 2021 09:06:50 -0800 Subject: [PATCH 2/3] Fixed issue #213 to lower logging level of spurious errors from 8T load balancing --- v3/newrelic/trace_observer.go | 19 ++++++++++++++++--- 1 file changed, 16 insertions(+), 3 deletions(-) diff --git a/v3/newrelic/trace_observer.go b/v3/newrelic/trace_observer.go index 738dd38da..784dfa921 100644 --- a/v3/newrelic/trace_observer.go +++ b/v3/newrelic/trace_observer.go @@ -272,9 +272,22 @@ func (to *gRPCtraceObserver) rcvResponses(spanClient v1.IngestService_RecordSpan for { s, err := spanClient.Recv() if nil != err { - to.log.Error("trace observer response error", map[string]interface{}{ - "err": err.Error(), - }) + // (issue 213) These two specific errors were reported as nuisance + // but are really harmless so we'll report them as DEBUG level events + // instead of ERROR. + // This error comes from our Infinite Tracing load balancers. + // We believe the EOF error comes from the gRPC getting reset every 30 seconds + // from the same cause (rebalancing 8T) + if err.Error() == "rpc error: code = Internal desc = stream terminated by RST_STREAM with error code: NO_ERROR" || err.Error() == "EOF" { + to.log.Debug("trace observer response error", map[string]interface{}{ + "err": err.Error(), + }) + } else { + to.log.Error("trace observer response error", map[string]interface{}{ + "err": err.Error(), + }) + } + // NOTE: even when the trace observer is shutting down // properly, an EOF error will be received here and a // supportability metric created. From 0a506ff3ebc20bb9daac2692ebddc82423b41fcd Mon Sep 17 00:00:00 2001 From: Steve Willoughby Date: Fri, 12 Mar 2021 09:14:47 -0800 Subject: [PATCH 3/3] updated changelog --- CHANGELOG.md | 3 +++ 1 file changed, 3 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index b78333682..96f9bca6a 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -2,6 +2,9 @@ ## Unreleased +### Changes +* Changed logging level for messages resulting from Infinite Tracing load balancing operations which were previously logged as errors; now they are debugging messages. [#213](https://github.com/newrelic/go-agent/issues/213) + ## 3.10.0 ### New Features