Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Follow-ups for Rails CSP nonce, #2544 #2556

Closed
kaylareopelle opened this issue Apr 15, 2024 · 5 comments · Fixed by #2544
Closed

Follow-ups for Rails CSP nonce, #2544 #2556

kaylareopelle opened this issue Apr 15, 2024 · 5 comments · Fixed by #2544

Comments

@kaylareopelle
Copy link
Contributor

Here are some follow-ups related to community-submitted PR #2544

  • Add unit tests for the change
  • Add a changelog entry for the change
  • Test the change when used in conjunction with NewRelic::Agent.browser_timing_header
@workato-integration
Copy link

https://new-relic.atlassian.net/browse/NR-259256

@kaylareopelle kaylareopelle linked a pull request Apr 15, 2024 that will close this issue
Rails CSP nonce auto inject #2544
Merged
8 tasks
@github-project-automation github-project-automation bot moved this from Triage to Code Complete/Done in Ruby Engineering Board Apr 18, 2024
@fallwith fallwith reopened this Apr 18, 2024
@github-project-automation github-project-automation bot moved this from Code Complete/Done to Triage in Ruby Engineering Board Apr 18, 2024
@fallwith
Copy link
Contributor

The PR is merged, but we still need to complete the CHANGELOG update a minimum on this one.

@workato-integration
Copy link

Work has been completed on this issue.

@github-project-automation github-project-automation bot moved this from Triage to Code Complete/Done in Ruby Engineering Board Apr 18, 2024
@fallwith fallwith reopened this Apr 18, 2024
@github-project-automation github-project-automation bot moved this from Code Complete/Done to Triage in Ruby Engineering Board Apr 18, 2024
@fallwith
Copy link
Contributor

Knock it off, workato.

@workato-integration
Copy link

Work has been completed on this issue.

@github-project-automation github-project-automation bot moved this from Triage to Code Complete/Done in Ruby Engineering Board Apr 18, 2024
@kaylareopelle kaylareopelle mentioned this issue Apr 18, 2024
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Ruby Engineering Board
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rails CSP nonce auto inject baldarn/newrelic-ruby-agent
2 participants
@fallwith @kaylareopelle