You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
NOTE: This is designed to be a complement to #2872 but if that issue has already been addressed by the time this one is worked on, the scope or need for this work may be impacted.
PR #2870 fixed a bug to allow the agent to support view_component v3.15.0+, which stemmed from the agent's use of private identifier method that was removed in v3.15.0. The bugfix works by not attempting to call identifier on newer view_component versions and simply using nil instead. This works great - and certainly is a big improvement over erroring out - but may potentially cause cardinality issues going forward given that all components will now produce similar metric names.
As mentioned in #2870 (comment), view_component itself makes use of self.class.source_location for the identifier value it creates an ActiveSupport notification with. Could we leverage a self.class.source_location call and massage the resulting value into a format suitable for a metric name?
The text was updated successfully, but these errors were encountered:
NOTE: This is designed to be a complement to #2872 but if that issue has already been addressed by the time this one is worked on, the scope or need for this work may be impacted.
PR #2870 fixed a bug to allow the agent to support view_component v3.15.0+, which stemmed from the agent's use of private
identifier
method that was removed in v3.15.0. The bugfix works by not attempting to callidentifier
on newer view_component versions and simply usingnil
instead. This works great - and certainly is a big improvement over erroring out - but may potentially cause cardinality issues going forward given that all components will now produce similar metric names.As mentioned in #2870 (comment), view_component itself makes use of
self.class.source_location
for the identifier value it creates an ActiveSupport notification with. Could we leverage aself.class.source_location
call and massage the resulting value into a format suitable for a metric name?The text was updated successfully, but these errors were encountered: