Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ViewComponent: evaluate the way that we obtain the component class identifier #2874

Closed
fallwith opened this issue Sep 30, 2024 · 1 comment · Fixed by #2907
Closed

ViewComponent: evaluate the way that we obtain the component class identifier #2874

fallwith opened this issue Sep 30, 2024 · 1 comment · Fixed by #2907
Assignees

Comments

@fallwith
Copy link
Contributor

NOTE: This is designed to be a complement to #2872 but if that issue has already been addressed by the time this one is worked on, the scope or need for this work may be impacted.

PR #2870 fixed a bug to allow the agent to support view_component v3.15.0+, which stemmed from the agent's use of private identifier method that was removed in v3.15.0. The bugfix works by not attempting to call identifier on newer view_component versions and simply using nil instead. This works great - and certainly is a big improvement over erroring out - but may potentially cause cardinality issues going forward given that all components will now produce similar metric names.

As mentioned in #2870 (comment), view_component itself makes use of self.class.source_location for the identifier value it creates an ActiveSupport notification with. Could we leverage a self.class.source_location call and massage the resulting value into a format suitable for a metric name?

@workato-integration
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants