Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecated Bundler::RubygemsIntegration#all_specs method #2885

Closed
excelsior opened this issue Oct 2, 2024 · 3 comments · Fixed by #2906
Closed

Deprecated Bundler::RubygemsIntegration#all_specs method #2885

excelsior opened this issue Oct 2, 2024 · 3 comments · Fixed by #2906
Assignees
@kaylareopelle
Labels
bug community To tag external issues and PRs submitted by the community oct-dec qtr Possible FY Q3 candidate
Milestone
Ruby Agent - FY25...

Comments

@excelsior
Copy link

The bug described in #2733 is still present in 9.14. Namely, the invocation here:

https://github.com/newrelic/newrelic-ruby-agent/blob/9.14.0/lib/new_relic/agent/instrumentation/grape.rb#L23

((Bundler.rubygems.respond_to?(:installed_specs) && Bundler.rubygems.installed_specs.map(&:name).include?('newrelic-grape')) ||
            Bundler.rubygems.all_specs.map(&:name).include?('newrelic-grape'))

This expression checks whether the newrelic-grape gem is present using the new method and, if it's not, calls the deprecated method.
@excelsior excelsior added the bug label Oct 2, 2024
@workato-integration
Copy link

https://new-relic.atlassian.net/browse/NR-321443

@github-actions github-actions bot added the community To tag external issues and PRs submitted by the community label Oct 2, 2024
@fallwith
Copy link
Contributor

fallwith commented Oct 2, 2024

Hi @excelsior. Thank you for bringing this to our attention!

@kford-newrelic kford-newrelic added the oct-dec qtr Possible FY Q3 candidate label Oct 8, 2024
@kford-newrelic kford-newrelic moved this from Triage to In Quarter in Ruby Engineering Board Oct 8, 2024
@kaylareopelle kaylareopelle mentioned this issue Oct 10, 2024
Merged
@kaylareopelle kaylareopelle self-assigned this Oct 10, 2024
@kaylareopelle kaylareopelle moved this from In Quarter to In Sprint in Ruby Engineering Board Oct 10, 2024
@github-project-automation github-project-automation bot moved this from In Sprint to Code Complete/Done in Ruby Engineering Board Oct 15, 2024
@kaylareopelle
Copy link
Contributor

Hi @excelsior, we have a fix for this bug queued up for our next release. I'll post here again when it's live.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kaylareopelle kaylareopelle

Labels
bug community To tag external issues and PRs submitted by the community oct-dec qtr Possible FY Q3 candidate
Projects
Ruby Engineering Board
Archived in project
Milestone
Ruby Agent - FY25Q3 KTLO & Instrument...
Development

Successfully merging a pull request may close this issue.

Create helper to access Bundler.rubygems specs newrelic/newrelic-ruby-agent
4 participants
@fallwith @excelsior @kford-newrelic @kaylareopelle