Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update context manager to store more than active segment #2495

Open
bizob2828 opened this issue Aug 19, 2024 · 1 comment
Open

Update context manager to store more than active segment #2495

bizob2828 opened this issue Aug 19, 2024 · 1 comment
Labels
points: 5 1-2 weeks

Comments

@bizob2828
Copy link
Member

Description

When we built the context manager we had a legacy async local. Since legacy is removed we should update the context manager to be able to store more than just the active segment. Right now we have no easy way to arbitrarily store context info with context manager without stomping on the segment. this is because in transaction/tracer/index.js we assume all calls to contextManger.getContext() are only the active segment. Once we update we should update the work done in #2437 to use this instead of its own instance of AsyncLocalStorage. We could potentially use this to store other instrumentation data that we now do via symbols and a lot of roundabout instrumentation.

Acceptance Criteria

Update context manager to allow storage of more than just the active segment and update places that call contextManager.getContext() to properly extract the active segment in those instances

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
points: 5 1-2 weeks
Projects
Status: Triage Needed: Unprioritized Features
Development

No branches or pull requests

2 participants