-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ionization energy & Fano Factor of Xenon gas #12
Comments
The problem I see is that these are not optical material properties, per se. However, we have no other places where we define material properties. If these are the only non-optical material properties throughout nexus, maybe we can leave them where they are now. |
Actually, the name OpticalMaterialProperties is misleading. In G4 these are just generic material properties tables. It just happens that most of them are optical stuff. For example, the scintillation parameters are also stored in these tables, which one may say has to do with optical properties, but not really (it doesn't say anything about how the photons interact with the material). I believe the material properties tables are just a very generic way for the user to hold any data related to the material and use it elsewhere in the physics code. |
Ok, so are you proposing to change the name to MaterialProperties, generically? I think it makes sense. |
It would be technically more correct and probably good enough to not confuse users. |
Currently these values are hard-coded into IonizationClustering.cc
These Xenon Gas properties should be set in OpticalMaterialProperties.cc, and IonizationClustering.cc get them from there. There is commented code ready to do this.
At the same time, we should check that the values set are the most updated ones.
The text was updated successfully, but these errors were encountered: