fix(oauth): support response_mode=form_post
#1669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensures we do this similarly than in other handlers like pkce, state, extendRes, callbackUrlHandler etc.
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/nextauthjs/next-auth/Eh754fScKyXw8ynJH998a5NUKxJA |
|
🎉 This PR is included in version 3.14.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 4.0.0-next.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
mnphpexpert
added a commit
to mnphpexpert/next-auth
that referenced
this pull request
Sep 2, 2024
* chore: alias dev script to next * feat(core): fallback to body when reading state * refactor: set csrfToken on req.options implicitly Ensures we do this similarly than in other handlers like pkce, state, extendRes, callbackUrlHandler etc. * chore: add code comment for debugging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Read
statefromreq.body, whenresponse_type=form_postis present.Why:
Currently, if the user requires
resposne_mode=form_postfor their provider (which is something we should consider as it is part of the OAuth spec: https://openid.net/specs/oauth-v2-form-post-response-mode-1_0.html), our implementation will fail to execute thestateand/orpkceverifications whenprotection: ["pkce", "state"](or similar) is set.How:
In the appropriate handler, we simply fall back to
req.body, ifreq.querydid not contain a value forstateRelated: #1664 (it although some advanced cookie will be needed for this to work properly. Please see #1664 (comment))