-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(provider): add Mailchimp provider #1781
feat(provider): add Mailchimp provider #1781
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/nextauthjs/next-auth/3H2s2aNuT3vboA9D5esL5d8U31u4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gotta love providers that implement OAuth in a way that "just works". 😁🎉 Nice PR, had a tiny comment, could you please check?
@michalbundyra my question stands about the scope. I wasn't curious if you can remove it but rather if it really works for you locally without providing any? I assumed that you would need something as basic as openid or something like that |
@balazsorban44 in my code I have empty string for scope and it works, but I'll verify it again and will be back here. Thanks |
thanks! I really appreciate it! could you please revert the src/providers/index.js file change? that file is auto-generated now |
773f58c
to
788a214
Compare
@balazsorban44 I checked again documentation and there is no single word about the scope. It works for me with empty scope tho. It's now rebased, so merge conflicts are resolved. Thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much!
🎉 This PR is included in version 3.16.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 4.0.0-next.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
What: add new provider - Mailchimp
Why: working in project where I am using this provider, so it might be useful also for others
How:
Checklist: