Skip to content
This repository has been archived by the owner on Nov 17, 2020. It is now read-only.

hiding external files does not work #39

Closed
sir-marc opened this issue Jun 7, 2018 · 7 comments
Closed

hiding external files does not work #39

sir-marc opened this issue Jun 7, 2018 · 7 comments
Labels

Comments

@sir-marc
Copy link

sir-marc commented Jun 7, 2018

The possibility to hide inline 'files' works just fine, but when trying to hide an external file it doesn't really work properly.
For example this works just fine:

```types.css hidden
body {
  background-color: red;
}```

whereas this does not work:

```types:../lib/style.css hidden```

It justs displays the content of the file in plain text inside the markup, see attached screenshot
bildschirmfoto 2018-06-07 um 17 41 43

@mpetrovich
Copy link
Owner

Thanks for reporting! We'll fix this soon.

@mpetrovich mpetrovich added the bug label Jun 7, 2018
@mpetrovich mpetrovich added this to the 3.x milestone Jun 9, 2018
@mpetrovich
Copy link
Owner

@sir-marc What version of Stylemark are you using? This works in v3.0 and was likely fixed in v1.0.1. Please upgrade to v2.x or greater and retest (v1.x is deprecated).

@mpetrovich mpetrovich removed this from the 3.x milestone Jun 9, 2018
@sir-marc
Copy link
Author

sir-marc commented Jun 9, 2018

@mpetrovich We are using version 3.0

@StuckiSimon
Copy link

@mpetrovich I've setup a quick repo using 3.0.0 to reproduce the issue: Stylemark Issue #39.

The generated stylemark documentation is available under: Demo

@mpetrovich
Copy link
Owner

This is was a weird one. When the external stylesheet has an empty newline at the end of the file, it works. But when it doesn't (in your case), it's not being handled correctly. Fixing now.

@mpetrovich mpetrovich added this to the 3.x milestone Jun 9, 2018
@mpetrovich
Copy link
Owner

mpetrovich commented Jun 10, 2018

Fixed in v3.0.1

StuckiSimon added a commit to Goldinteractive/gold-features that referenced this issue Jun 10, 2018
@mpetrovich
Copy link
Owner

FYI in case it's relevant, along the way I discovered a bug with the way external wildcard references are handled: #41

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants