Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Round background of AppNavigationItem #2460

Closed
marcoambrosini opened this issue Jan 20, 2022 · 7 comments · Fixed by #2571
Closed

Round background of AppNavigationItem #2460

marcoambrosini opened this issue Jan 20, 2022 · 7 comments · Fixed by #2571
Assignees
Labels
design Design, UX, interface and interaction design discussion Need advices, opinions or ideas on this topic feature: app-navigation Related to the app-navigation component

Comments

@marcoambrosini
Copy link
Contributor

Time to do it? @jancborchardt @nimishavijay

Screen.Recording.2022-01-20.at.13.10.49.mov
@marcoambrosini marcoambrosini added design Design, UX, interface and interaction design discussion Need advices, opinions or ideas on this topic labels Jan 20, 2022
@marcoambrosini
Copy link
Contributor Author

var(--border-radius-large) looks prob nicer than var(--border-radius-pill)

Screen.Recording.2022-01-20.at.13.16.42.mov

@jancborchardt
Copy link
Contributor

Yesss, looks very nice! :) Also agree with you that the large birder radius fits better than pill, so it's the same as the AppContentList rather than buttons.

@jancborchardt jancborchardt added the feature: app-navigation Related to the app-navigation component label Mar 9, 2022
@jancborchardt
Copy link
Contributor

I’d propose this for planning since it will pull the navigation design in line with the rest of the updates, and would be nice for a visual refresh.

Probably best-fitting for Groupware team since it impacts Mail, Calendar and Contacts (however we need to make sure to also update the legacy styles used in Files), possibly with guidance from @marcoambrosini.
What do you think @AndyScherzinger @ChristophWurst @nickvergessen?

@marcoambrosini
Copy link
Contributor Author

@quentinguidee all yours :)

@AndyScherzinger
Copy link
Contributor

AndyScherzinger commented Mar 23, 2022

What do you think @AndyScherzinger

I agree with your assessment Jan!

@GretaD
Copy link
Contributor

GretaD commented May 30, 2022

@jancborchardt @nimishavijay @marcoambrosini should we do the same for ActionButton?
It will look like this
actionbutton

@nimishavijay
Copy link

Yes, we should ideally change the action menu as well.
If we are adding a border radius to the menu item, there should be a border radius for the action menu itself, and a few pixels space between the action item and the action menu.
Something like this nextcloud/mail#6200 (comment) should work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design Design, UX, interface and interaction design discussion Need advices, opinions or ideas on this topic feature: app-navigation Related to the app-navigation component
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants