Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ActionInput: Fix documentation or add inheritAttrs: true #2479

Open
st3iny opened this issue Feb 8, 2022 · 0 comments
Open

ActionInput: Fix documentation or add inheritAttrs: true #2479

st3iny opened this issue Feb 8, 2022 · 0 comments
Labels
discussion Need advices, opinions or ideas on this topic feature: documentation Related to the documentation

Comments

@st3iny
Copy link
Contributor

st3iny commented Feb 8, 2022

ActionInput has inheritAttrs: false but tries to inherit attrs. Either add inheritAttrs: true or change the documentation.

Take a look at the second sentence of the documentation of ActionLink. Currently, it is not entirely true as inheritAttrs is false:
All undocumented attributes will be bound to the input, the datepicker or the multiselect component, e.g. maxlength, not-before.

Originally posted by @tcitworld in #2472 (comment)

@st3iny st3iny changed the title Indeed, so shouldn't we add inheritAttrs: false instead of this prop to match the documented behavior? ActionInput: Fix documentation or add inheritAttrs: true Feb 8, 2022
@st3iny st3iny added discussion Need advices, opinions or ideas on this topic feature: documentation Related to the documentation labels Feb 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion Need advices, opinions or ideas on this topic feature: documentation Related to the documentation
Projects
None yet
Development

No branches or pull requests

1 participant