Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slow menu opening since nc 7 #3300

Closed
skjnldsv opened this issue Sep 27, 2022 · 7 comments
Closed

Slow menu opening since nc 7 #3300

skjnldsv opened this issue Sep 27, 2022 · 7 comments
Labels
1. to develop Accepted and waiting to be taken care of regression Regression of a previous working feature

Comments

@skjnldsv
Copy link
Contributor

image

400ms to open a menu is not acceptable, debugging the profiler gives the above culprit.
Something must have changed.

It request an animation frame and block the browser whch drop my fps to 2.
I have 45GB of free ram and 4 full cpu core available (intel i5, so hardware is not an issue)

@raimund-schluessler @marcoambrosini

@skjnldsv skjnldsv added 1. to develop Accepted and waiting to be taken care of regression Regression of a previous working feature labels Sep 27, 2022
@raimund-schluessler
Copy link
Contributor

There is not really any difference of NcActions between stable6 and master:
https://github.com/nextcloud/nextcloud-vue/compare/stable6#diff-a09afa053a2a82c8e733f6d785927c30bcb3f0969d82f5ccfda36861a4af553d

@raimund-schluessler
Copy link
Contributor

@skjnldsv Maybe this is related to the focus-trap issue #3154 (comment)

@skjnldsv
Copy link
Contributor Author

Might be! 🤷

@raimund-schluessler
Copy link
Contributor

@skjnldsv @vinicius73 Is this fixed with #3347?

@skjnldsv
Copy link
Contributor Author

Should be yes

@skjnldsv
Copy link
Contributor Author

But this wasnot included in 7.0.0 :(

@raimund-schluessler
Copy link
Contributor

But this wasnot included in 7.0.0 :(

Looks like 7.0.1 needs to come soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop Accepted and waiting to be taken care of regression Regression of a previous working feature
Projects
None yet
Development

No branches or pull requests

2 participants