Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cypress failures on master #3430

Closed
PVince81 opened this issue Nov 2, 2022 · 4 comments
Closed

Cypress failures on master #3430

PVince81 opened this issue Nov 2, 2022 · 4 comments
Labels
3. to review Waiting for reviews bug Something isn't working regression Regression of a previous working feature

Comments

@PVince81
Copy link
Contributor

PVince81 commented Nov 2, 2022

All PRs failing recently, even translation ones: #3427

        Spec                                              Tests  Passing  Failing  Pending  Skipped  
  ┌────────────────────────────────────────────────────────────────────────────────────────────────┐
  │ ✖  components/NcAppSidebar/NcAppSideba      01:12       48       24       24        -        - │
  │    r-compact.visual.js                                                                         │
  ├────────────────────────────────────────────────────────────────────────────────────────────────┤
  │ ✖  components/NcAppSidebar/NcAppSideba      01:09       48       24       24        -        - │
  │    r.visual.js                                                                                 │
  └────────────────────────────────────────────────────────────────────────────────────────────────┘
    ✖  2 of 2 failed (100%)                     02:22       96       48       48        -        -
@PVince81 PVince81 added bug Something isn't working regression Regression of a previous working feature labels Nov 2, 2022
@PVince81 PVince81 mentioned this issue Nov 2, 2022
Merged
@PVince81
Copy link
Contributor Author

PVince81 commented Nov 2, 2022

seems the first failure is likely #3401
the PR before that (chronologically) passed

@skjnldsv

@PVince81
Copy link
Contributor Author

PVince81 commented Nov 2, 2022

ref: #3402

@skjnldsv
Copy link
Contributor

skjnldsv commented Nov 2, 2022

yes, we need server dialogs fix

@skjnldsv skjnldsv mentioned this issue Nov 2, 2022
Merged
@skjnldsv skjnldsv added the 3. to review Waiting for reviews label Nov 2, 2022
@raimund-schluessler
Copy link
Contributor

Fixed with #3402.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
3. to review Waiting for reviews bug Something isn't working regression Regression of a previous working feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@PVince81 @raimund-schluessler @skjnldsv