Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NcActions with tertiary-no-background has background when open #3720

Closed
susnux opened this issue Feb 5, 2023 · 2 comments · Fixed by #3724
Closed

NcActions with tertiary-no-background has background when open #3720

susnux opened this issue Feb 5, 2023 · 2 comments · Fixed by #3724
Labels
0. to triage design Design, UX, interface and interaction design feature: actions Related to the actions components

Comments

@susnux
Copy link
Contributor

susnux commented Feb 5, 2023

When using the type tertiary-no-background I would expect the actions toggle to never have a background assigned, but when the actions are toggled the button gets the default background assigned.

This looks a bit odd in my case:
button with background overlays an input element

@susnux susnux added bug Something isn't working feature: actions Related to the actions components 0. to triage labels Feb 5, 2023
@raimund-schluessler raimund-schluessler added design Design, UX, interface and interaction design and removed bug Something isn't working labels Feb 6, 2023
@raimund-schluessler
Copy link
Contributor

That's a question for @nextcloud/designers. But I have to agree. It would be more consistent, as the NcButton component of type tertiary-no-background has no background on click either.

The fix would be to add

	&.action-item--tertiary-no-background {
		--open-background-color: transparent;
	}

before this:
https://github.com/nextcloud/nextcloud-vue/blob/27d09d66f582cedccdcb34223368d70daab06904/src/components/NcActions/NcActions.vue#L1172-L1175

@raimund-schluessler
Copy link
Contributor

I took the liberty to create a PR, so one can check it out live: #3724.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0. to triage design Design, UX, interface and interaction design feature: actions Related to the actions components
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants