X-NC-GROUP-ID not removed properly

[pulcov]

Steps to reproduce

1. Create event with nextcloud web interface and set popup alarm
2. Sync with android phone
3. Wait popup on phone

Expected behaviour

Popup is shown

Actual behaviour

Nothing is happening

Server configuration

Calendar version:
1.5.0

Android version:
5.1 and 6.0

---

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

[georgehrke]

How do you connect your Android to Nextcloud?

[pulcov]

Sync is make with Davdroid.

Android have a bug with X-NC-GROUP-ID in ACTION property. If i remove this property by disabling this lines, problem is solved :
simpleEventModel.js#L135
simpleEventModel.js#L344-L345

Is this property is essential ?

[georgehrke]

Is this property is essential ?

It's essential when opening events in the editor, but there has been issues with removing them after editing events in the past. (And I have to check if they are removed when cancelling editing).

Android have a bug with X-NC-GROUP-ID in ACTION property.

But that's indeed a bug thats not on our side. We can add any X- parameter to the action property we want and it would still be valid calendar data.

Do you know if this is a bug with DavDroid or Android?

[pulcov]

Thank's for your answer.

For me, isn't a DavDroid bug, it's a Android bug.
Below, logs extract from Davdroid :

2017-02-14 12:28:46 2 [HttpClient$1] Content-Type: text/calendar; charset=utf-8; component=vevent
2017-02-14 12:28:46 2 [HttpClient$1]
2017-02-14 12:28:46 2 [HttpClient$1] BEGIN:VCALENDAR
PRODID:-//Nextcloud calendar v1.5.0
VERSION:2.0
CALSCALE:GREGORIAN
BEGIN:VEVENT
CREATED:20170214T113154
DTSTAMP:20170214T113154
LAST-MODIFIED:20170214T113154
UID:05RKYZIUO0OUM7H0A0SPL
SUMMARY:TEST
CLASS:PUBLIC
STATUS:CONFIRMED
DTSTART;TZID=Europe/Berlin:20170214T130000
DTEND;TZID=Europe/Berlin:20170214T140000
BEGIN:VALARM
ACTION;X-NC-GROUP-ID=0:DISPLAY
TRIGGER:-PT15M
END:VALARM
END:VEVENT
BEGIN:VTIMEZONE
...
END:VTIMEZONE
END:VCALENDAR
2017-02-14 12:28:46 2 [HttpClient$1] <-- END HTTP (2554-byte body)
2017-02-14 12:28:46 2 [ical4android.Event] Parsing iCalendar stream
2017-02-14 12:28:48 2 [ical4android.Event] Assigning exceptions to master events
2017-02-14 12:28:48 2 [syncadapter.CalendarSyncManager] Updating Nextcloud-3756H28VQFH45MVX6ZZN45.ics in local calendar
2017-02-14 12:28:48 2 [ical4android.AndroidEvent] Built event object
PARAMETER #1 = mType: 1, mUri: content://com.android.calendar/events?account_name=Vince&account_type=bitfire.at.davdroid&caller_is_syncadapter=true&account_name=Vince&account_type=bitfire.at.davdroid&caller_is_syncadapter=true, mSelection: null, mExpectedCount: null, mYieldAllowed: false, mValues: eventTimezone=Europe/Berlin title=TEST availability=0 eventStatus=1 dtend=1487077200000 hasAttendeeData=1 allDay=0 dtstart=1487073600000 calendar_id=18 eventEndTimezone=Europe/Berlin accessLevel=3, mValuesBackReferences: null, mSelectionArgsBackReferences: null
2017-02-14 12:28:48 2 [ical4android.AndroidEvent] Adding alarm 15 minutes before event, method: 0

[pulcov]

I make another test. I sending event without X-NC-GROUP-ID.
Below, DavDroid logs :

2017-02-14 14:54:34 2 [HttpClient$1] Content-Type: text/calendar; charset=utf-8; component=vevent
2017-02-14 14:54:34 2 [HttpClient$1]
2017-02-14 14:54:34 2 [HttpClient$1] BEGIN:VCALENDAR
PRODID:-//Nextcloud calendar v1.5.0
VERSION:2.0
CALSCALE:GREGORIAN
BEGIN:VEVENT
CREATED:20170214T145338
DTSTAMP:20170214T145338
LAST-MODIFIED:20170214T145338
UID:YZK8RNMZ58ESAKNP9G818
SUMMARY:TEST
CLASS:PUBLIC
STATUS:CONFIRMED
DTSTART;TZID=Europe/Berlin:20170214T150000
DTEND;TZID=Europe/Berlin:20170214T160000
BEGIN:VALARM
ACTION:DISPLAY
TRIGGER:-PT15M
END:VALARM
END:VEVENT
BEGIN:VTIMEZONE
...
END:VTIMEZONE
END:VCALENDAR
2017-02-14 14:54:34 2 [HttpClient$1] <-- END HTTP (2538-byte body)
2017-02-14 14:54:34 2 [ical4android.Event] Parsing iCalendar stream
2017-02-14 14:54:36 2 [ical4android.Event] Assigning exceptions to master events
2017-02-14 14:54:36 2 [syncadapter.CalendarSyncManager] Adding Nextcloud-1F7N38EKLQ2FC0321902SA.ics to local calendar
2017-02-14 14:54:36 2 [ical4android.AndroidEvent] Built event object
PARAMETER #1 = mType: 1, mUri: content://com.android.calendar/events?account_name=Vince&account_type=bitfire.at.davdroid&caller_is_syncadapter=true&account_name=Vince&account_type=bitfire.at.davdroid&caller_is_syncadapter=true, mSelection: null, mExpectedCount: null, mYieldAllowed: false, mValues: eventTimezone=Europe/Berlin title=TITI availability=0 eventStatus=1 dtend=1487084400000 hasAttendeeData=1 allDay=0 dtstart=1487080800000 calendar_id=18 eventEndTimezone=Europe/Berlin accessLevel=3, mValuesBackReferences: null, mSelectionArgsBackReferences: null
2017-02-14 14:54:36 2 [ical4android.AndroidEvent] Adding alarm 15 minutes before event, method: 1

I notice a difference :
With X-NC-GROUP-ID

2017-02-14 12:28:48 2 [ical4android.AndroidEvent] Adding alarm 15 minutes before event, method: 0

Without X-NC-GROUP-ID

2017-02-14 14:54:36 2 [ical4android.AndroidEvent] Adding alarm 15 minutes before event, method: 1

I corrected my last words, it's maybe a davdroid bug. I will open a ticket to the davdroid team.

Thanks

[pulcov]

DavDroid topic

[rfc2822]

Has been fixed in DAVdroid.

[georgehrke]

cool, thx! :)

Lets keep this issue open, because I consider not removing X-NC-GROUP-ID an unwanted behavior.

[pulcov]

thx all!