Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Displayname is missing on public sharing site #596

Closed
georgehrke opened this issue Sep 12, 2017 · 3 comments · Fixed by #712
Closed

Displayname is missing on public sharing site #596

georgehrke opened this issue Sep 12, 2017 · 3 comments · Fixed by #712
Labels
Milestone

Comments

@georgehrke
Copy link
Member

works on Nextcloud 11, is broken on Nextcloud 12 and master

It's supposed to show the displayname, but it shows the user id.
Might be a server-side issue. Subject to investigation.

847b51f4-baf0-473f-9271-57dc0db21b61

@georgehrke georgehrke added 1. to develop Accepted and waiting to be taken care of bug priority labels Sep 12, 2017
@georgehrke georgehrke added this to the 1.6.0-current milestone Sep 12, 2017
@nickvergessen
Copy link
Member

Also most of the time displaying this message might also look a bit stupid.
E.g. I embeded a calendar on our website, and no the calendar is not "shared" with teh visitor, it's embeded on the website, so not displaying this message would be desired...

@georgehrke
Copy link
Member Author

E.g. I embeded a calendar on our website, and no the calendar is not "shared" with teh visitor, it's embeded on the website, so not displaying this message would be desired...

I think in that case we should introduce a new design for embedding. Where we put the month name, view names and today above the grid and make the grid full width.

cc @jancborchardt

@jancborchardt
Copy link
Member

jancborchardt commented Oct 28, 2017

Yup @georgehrke, good call on special embedding view without sidebar.

Still, this issue is separate and should be fixed, as embedding is definitely not the only/main case for calendar sharing. :)

@georgehrke georgehrke added 3. to review Waiting for reviews and removed 1. to develop Accepted and waiting to be taken care of labels Jan 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants