Don't make the window disappear when the user clicks outside of this window

[waazdakka]

Steps to reproduce

1. Click to create a new event
2. Start to enter infos
3. Click on the time selector (or just go to the 4.)
4. Click somewhere before clicking on minutes selector (on the whole event window or somewhere on the page) to close the time selector
5. Rage seeing the whole event's window disappear (full of fresh-new infos)

Expected behaviour

Don't make the event's popup disappear when the user clicks outside of this window : it may results in crisis when you just entered for the third time all informations about the event you want to create in your planning.
Maybe the event could be saved as draft... or even created

Actual behaviour

When an user click outside of the event's window, this window just disappear, while the user had already fill some fields.

Calendar version: (see the apps page)
1.6.1

Client configuration

Firefox / Chrome

---

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

[weeman1337]

Jep - this happens for me nearly every time creating an event via the web interface. Sometimes it doesn't happen intentionally. It's more like I didn't hit the create button and clicked out of the window → everything is gone :/

I could imagine it working like this:

• when clicking another day: keep the inputs and change the date
• when clicking outside of the calendar, close the window
  • clicking a day again → reopen the create dialog and restore the inputs

What do you think @nextcloud/calendar @nextcloud/designers (I hope designers is right here - somehow for me the group targets usability, too)

[georgehrke]

@weeman1337 Hey, since you seem to be looking into this issue: Please note that we are currently migrating the app to Vue.js: #926

[georgehrke]

To answer your actual question ... 😉

when clicking another day: keep the inputs and change the date

I like this idea 👍

when clicking outside of the calendar, close the window

We could also just keep the dialog open and only close it when the user actually clicks the cancel button / the x or presses the escape key.

[jancborchardt]

We have 2 requirements:

• Data should not get lost unexpectedly
• People are used to clicking the outside of dialogs to close them

So clicking outside of the dialog should close it, but also save changes. Changes only don’t get saved when you click the x button (should get a "Cancel" tooltip).

[georgehrke]

So clicking outside of the dialog should close it, but also save changes. Changes only don’t get saved when you click the x button (should get a "Cancel" tooltip).

So you are saying clicking outside the dialog should have the same effect as clicking the Update / Save button?

[georgehrke]

Just to be clear about the original issue: When the date-time-picker is open, clicking outside the window should only close the date-time-picker, not the window.

[jancborchardt]

So you are saying clicking outside the dialog should have the same effect as clicking the Update / Save button?

Yes. Do you disagree? What’s happening in macOS Calendar?

[weeman1337]

I planned to wait for

Please note that we are currently migrating the app to Vue.js: #926

But that still seems to be some time in the future.

I've looked into the code today (for hours) and couldn't figure out how the event flow is working. So I gave it up. Regarding the issue I think it is intended to keep the event data if another day is clicked, see: https://github.com/nextcloud/calendar/blob/master/js/app/service/eventseditordialogservice.js#L123

Maybe someone who is firm with the code could have a look at this.

[armaccloud]

To answer your actual question ... wink

when clicking another day: keep the inputs and change the date

I like this idea +1

when clicking outside of the calendar, close the window

We could also just keep the dialog open and only close it when the user actually clicks the cancel button / the x or presses the escape key.

Since the last update, the escape key isn't working to close the window anymore. Will this come back the the resolution of this issue?