Replace h2 in empty content with h1

[max-nextcloud]

On the initial landing page there is no heading of level one (h1). The landing page heading is h2 at the moment.

For good accessibility with screen readers it's recommended to not skip heading levels and therefore start with an h1:

it is important to not skip one or more heading levels. Doing so may create confusion, as the person navigating this way may be left wondering where the missing heading is.

Screenshot ("Collectives" is the h2):

Originally posted by @mspae in #159 (comment)

[max-nextcloud]

Turns out this is not as easy as i thought it was. The component used here is an NcEmptyContent - and that uses h2 tags for the title. So we'd need to make that component configurable.

[ChristophWurst]

there is no heading of level one (h1)

There should be one: https://github.com/nextcloud/server/blob/c10317f7f9f53a4de464915f754896eed7f1ee6c/core/templates/layout.user.php#L126-L128

[max-nextcloud]

I'm pretty sure there's none in our case:

I think that's because we are using our own template.
But you're right we could also add the heading to the template or to the main section as a visually hidden h1.

[ChristophWurst]

TemplateResponse should still extend the server layouts AFAIK

[max-nextcloud]

TemplateResponse should still extend the server layouts AFAIK

Looks like we are repacing the entire main#content just like the app tutorial.

So we probably should stop doing that.

[ChristophWurst]

Whoops. Good catch!

[max-nextcloud]

Looks like replacing main#content is a good option as this allows us to use NcAppContent which also has a main element and there may only be one in the dom.

So i will continue trying to turn the h2 into an h1.

[JuliaKirschenheuter]

Please pay attention on this existing ticket: nextcloud/server#35626 (comment), nextcloud/server#35626 (comment). I already working on replacing headings in meaningful way. I haven't touched Collective apps yet, but probably would have a solution for all apps.