-
Notifications
You must be signed in to change notification settings - Fork 793
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix bulk upload of empty files #5871
Conversation
require also a fix from server nextcloud/server#39221 |
02beb67
to
1fb6fb7
Compare
/backport to stable-3.9 |
@mgallien Looks nice, but I am still getting an error when syncing an empty file: [WARNING] Could not complete propagation of "New Text Document (5).txt" by OCC::BulkPropagatorJob(0x2b23bd9f650) with status OCC::SyncFileItem::NormalError and error: "Network error: 302" |
there are server side changes needed for a full fix |
force an empty body when we bulk upload empty files force a "valid" checksum to be computed for empty files as bulk upload server side expects a checksum even for empty files Close #5824 Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
1fb6fb7
to
8cd1a30
Compare
got it, approved, but could not test of course |
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #5871 +/- ##
=======================================
Coverage 60.08% 60.08%
=======================================
Files 145 145
Lines 18715 18711 -4
=======================================
- Hits 11244 11242 -2
+ Misses 7471 7469 -2
|
Kudos, SonarCloud Quality Gate passed! |
AppImage file: nextcloud-PR-5871-5540f7f0f4dde32c874ddd6e20508ba911497c1b-x86_64.AppImage |
@mgallien do this also fix ? #5758 (comment) looks like the same issue to me ? |
force an empty body when we bulk upload empty files
force a "valid" checksum to be computed for empty files as bulk upload server side expects a checksum even for empty files
Close #5824