Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guests whitelist revision #1249

Open
Antreesy opened this issue Oct 8, 2024 · 1 comment
Open

Guests whitelist revision #1249

Antreesy opened this issue Oct 8, 2024 · 1 comment
Labels
0. Needs triage Pending approval or rejection. This issue is pending approval. enhancement New feature or request feature: whitelist

Comments

@Antreesy
Copy link

Antreesy commented Oct 8, 2024

Ref source:

public const WHITELIST_ALWAYS = ',core,theming,settings,avatar,files,heartbeat,dav,guests,impersonate,accessibility,terms_of_service';
public const DEFAULT_WHITELIST = 'files_trashbin,files_versions,files_sharing,files_texteditor,text,activity,firstrunwizard,photos,notifications,dashboard,user_status,weather_status';

WHITELIST_ALWAYS and DEFAULT_WHITELIST could be updated to include some more of the apps shipped (and enabled by default) with Nextcloud core, to avoid confusion like "Guest account can't preview PDF files", as files_pdfviewer is not included in the default list.

https://github.com/nextcloud/server/blob/356f3ded52cf48a26295daef96c032d6d087a518/core/shipped.json#L56

@Antreesy Antreesy added 0. Needs triage Pending approval or rejection. This issue is pending approval. enhancement New feature or request feature: whitelist labels Oct 8, 2024
@sebastiaanveld
Copy link

sebastiaanveld commented Nov 23, 2024

Guess this is related to #380 and #149

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0. Needs triage Pending approval or rejection. This issue is pending approval. enhancement New feature or request feature: whitelist
Projects
None yet
Development

No branches or pull requests

2 participants