Remote semantics of h6 in user bubble #1586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PVince81
added
bug
PVince81
requested review from
ChristophWurst,
juliusknorr and
marcoambrosini
juliusknorr
approved these changes
Nov 19, 2020
skjnldsv
approved these changes
Nov 23, 2020
skjnldsv
reviewed
Nov 23, 2020
| @@ -94,7 +94,7 @@ This component has the following slot: | |||
| class="user-bubble__avatar" /> | |||
|
|
|||
| <!-- Title --> | |||
| <h6 class="user-bubble__title"> | |||
| <h6 class="user-bubble__title" role="presentation"> | |||
There was a problem hiding this comment.
Do we still need the h6 then? I am not sure that make sense if we strip of their default role
There was a problem hiding this comment.
we don't really, could use a div instead and need to check that the styling stays the same
There was a problem hiding this comment.
span then if it's just text
marcoambrosini
approved these changes
Nov 23, 2020
We should not use headers like this for styling as it makes screen readers read them out as "headling level 6". Signed-off-by: Vincent Petry <vincent@nextcloud.com>
PVince81
force-pushed
the
bugfix/noid/dont-say-h6
branch
from
21af00f
to
1b76929
Compare
|
I've replaced it now with a span and checked side by side with the old style: they look identical. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will prevent screen readers to say "Heading level 6" + the
contents instead of just reading the contents.
Tested with Orca and Firefox.