Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CheckboxRadio component #1875

Merged
merged 1 commit into from
Apr 27, 2021
Merged

Add CheckboxRadio component #1875

merged 1 commit into from
Apr 27, 2021

Conversation

skjnldsv
Copy link
Contributor

@skjnldsv skjnldsv commented Apr 23, 2021

  • Uses the Material design icons
  • Supports simple, sets and single-set checkboxes + radio (see docs)
  • Supports indeterminate state
  • Very straightforward! 🚀

A few examples:
image
image
image

@skjnldsv skjnldsv added enhancement New feature or request 3. to review Waiting for reviews labels Apr 23, 2021
@skjnldsv skjnldsv added this to the 4.0.0 milestone Apr 23, 2021
@skjnldsv skjnldsv self-assigned this Apr 23, 2021
@skjnldsv skjnldsv force-pushed the enh/checkbox-radio branch 3 times, most recently from 1a82eed to 2edf378 Compare April 23, 2021 17:28
@jancborchardt
Copy link
Contributor

Wooooooah very nice! :) Sooo good to have this standardized.

Some design feedback:

  • Each of the rows should be 44px height to conform to the min clickable/tappable area. The resulting whitespace will also look nice as separation.
  • The radio set using checkmarks looks a bit off. Normally it’s a dot in a circle, like so https://material.io/develop/web/components/selection-controls/radio-buttons (and like we do currently already)
  • What is the "Standard checkbox set" with a square inside the square? If that is the indeterminate setting – we should keep it how it looks like for us currently (with the dash/minus in there) since that is also kind of a standard: https://material.io/components/checkboxes#behavior

Copy link
Contributor

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, works very well now, looks great and is accessible. 👍 design-wise!

@skjnldsv skjnldsv force-pushed the enh/checkbox-radio branch 2 times, most recently from 96b6695 to 7af8a32 Compare April 24, 2021 06:56
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@ChristophWurst ChristophWurst merged commit 2caf2de into master Apr 27, 2021
@ChristophWurst ChristophWurst deleted the enh/checkbox-radio branch April 27, 2021 08:33
@skjnldsv skjnldsv mentioned this pull request Jun 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants